Can't create zip archive on external disk when local disk has not enough space for temporary file

[davidak]

What Happened?

I tried to create a zip archive on an SMB (Samba) share of a folder with 15 GB data.

It always fails with this unhelpful error.

I watched the free disk space on the local disk and it turns out, the zip archive is temporary created on the local disk and then moved, but the local disk does not have enough space free. It works when compressing a smaller folder.

https://www.youtube.com/watch?v=_gbEWEj7Kvc

Compressing this 15.3 GB folder needs about 25 GB temporary free disk space.

The final zip archive on the SMB share is 13.7 GB and it looks like this much space is not freed on my local disk after compressing is finished!

Steps to Reproduce

0. watch free disk space: watch -d -n 0.5 "df -h | grep /dev/dm-2 (use your device where / is mounted)
1. right click folder in files
2. Click "Compress"
3. Select "Location" on an SMB share (or anywhere not on the / partition)
4. Click "Create" button

Expected Behavior

features should work and errors should be helpful

always check if the space to create files is free. maybe not only for archives, but for any file save! could you implement that in granite?
investigate if the zip file could directly be created on the final location, so this still works when local disk is full
if you fail to find an elegant solution, at least give the user useful feedback, like "not enough space available on DISKNAME to create temporary archive file"
show in the dialog that the file is moved from temp location to final location. it's currently intransparent what is happening! https://youtu.be/KMllcb92XQ8?t=168

OS Version

Other Linux

NixOS 22.11.4021.54495a4eafe

Software Version

Older release (I have not run all updates)

elementary-files-6.2.1

Log Output

i did start files from terminal, but got no output

Hardware Info

Lenovo Thinkpad X230
Ethernet connection

[jeremypw]

Files subcontracts file compression to FileRoller (https://github.com/elementary/fileroller) whence the error message comes so I think this issue should be moved there.

[Marukesu]

I believe the policy here is that patches applied here should be minimal, if this is a issue that comes from upstream, then it should be reported there. and we pick the fixes when a newer version get released.