Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off "Other" notifications by default in Juno #14

Open
cassidyjames opened this issue Dec 13, 2017 · 4 comments · Fixed by #15
Open

Turn off "Other" notifications by default in Juno #14

cassidyjames opened this issue Dec 13, 2017 · 4 comments · Fixed by #15
Milestone

Comments

@cassidyjames
Copy link
Contributor

cassidyjames commented Dec 13, 2017

We want to encourage apps to use the notifications API properly with the freedesktop ID and everything. In Loki, we grouped all non-compliant apps together under "Other" in the Notifications plug. In Juno, I think we should turn those notifications off by default.

This means that out of the box:

  1. Apps using the API properly work as expected.
  2. Apps not using the API properly can update to use the API properly to get notifications back on by default.
  3. Apps not using the API that don't update can still be opted into by the user by switching on "Other"
@danirabbit
Copy link
Member

Something kind of annoying that I noticed about this is that some apps (like Slack and Mumble) send notification sounds themselves instead of using the notifications server. This means that bubbles can be disabled, but notification sounds cannot.

@danirabbit danirabbit modified the milestones: juno-beta1, juno-beta2 Mar 13, 2018
@danirabbit
Copy link
Member

It looks like Corentin's patch was merged into Electron so that those apps should identify themselves correctly in the future: https://github.com/electron/electron/blob/master/brightray/browser/linux/libnotify_notification.cc#L127

@cassidyjames
Copy link
Contributor Author

This was not fixed by patching the OS settings, as there is not a schema defined for that key; the Notifications plug creates it on the fly. I think we'll have to define the schema for gala-other in the build system for Gala itself instead.

@BNolet
Copy link

BNolet commented Sep 27, 2018

Should this be closed? Does this mean Juno release is close? :D

@cassidyjames cassidyjames modified the milestones: juno-beta1, juno-rc1 Oct 2, 2018
@cassidyjames cassidyjames removed their assignment Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants