Persist current search term until intentionally changed #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reverting to draft after some issues came to light while dog-fooding |
|
Outstanding issues should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1508
This PR results in the search term persisting until editing or closing the search bar. Making a new selection in the document no longer replaces the search term in the searchbar until
Control + Fis pressed again (Control + Gcontinues to search the current search term).To be confirmed: Should an existing search term be cleared on pressing
Control + F? As it is unclear whether the user intends to start a completely new search or modify the current one it is left for the user atm.The search term is cleared when the searchbar is hidden.
The code is somewhat simpler and DRYer.
The searchbar is made more self-contained - it now includes the revealer and hides some of its internal working from MainWindow. Some names are made more accurately descriptive of what they are/do.