Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sliding Sync: Support filtering by 'tags' / 'not_tags' in SSS #17662

Merged
merged 12 commits into from
Sep 13, 2024
Merged

Sliding Sync: Support filtering by 'tags' / 'not_tags' in SSS #17662

merged 12 commits into from
Sep 13, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Sep 4, 2024 •
edited by MadLittleMods
Loading

This appears to be enough to make Element Web work (or at least move it on to the next hurdle), although I'm not super confident in it, especially the tests since the is_dm tests were testing a different filter method. The tests are also just at the lowest unit level rather than anything higher. I'm not sure what the difference is between the two filter methods - I guess we would need to add both?

Simplified Sliding Sync (SSS)

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@dbkr dbkr marked this pull request as ready for review September 4, 2024 20:02
@dbkr dbkr requested a review from a team as a code owner September 4, 2024 20:02
@MadLittleMods MadLittleMods changed the title Support filtering by 'tags' / 'not_tags' in SSS Sliding Sync: Support filtering by 'tags' / 'not_tags' in SSS Sep 11, 2024
MadLittleMods
MadLittleMods requested changes Sep 11, 2024
View reviewed changes
synapse/handlers/sliding_sync/room_lists.py Outdated Show resolved Hide resolved
tests/handlers/test_sliding_sync.py Outdated Show resolved Hide resolved
synapse/handlers/sliding_sync/room_lists.py Outdated Show resolved Hide resolved
tests/handlers/test_sliding_sync.py Outdated Show resolved Hide resolved
tests/handlers/test_sliding_sync.py Outdated Show resolved Hide resolved
tests/handlers/test_sliding_sync.py Outdated Show resolved Hide resolved
@MadLittleMods MadLittleMods mentioned this pull request Sep 11, 2024
Merged
3 tasks
MadLittleMods added a commit that referenced this pull request Sep 12, 2024
@MadLittleMods
Sliding Sync: Move filters tests to rest layer (#17703)
9b83fb7 
Move filters tests to rest layer in order to test the new (with sliding
sync tables) and fallback paths that Sliding Sync can use.

Also found a bug in the new path because it's not being tested which is
also fixed in this PR. We now take into account `has_known_state` when
filtering.

Spawning from
#17662 (comment).
This should have been done when we started using the new sliding sync
tables in #17630
devonh
devonh approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

Thanks for taking this over and pushing it through

synapse/handlers/sliding_sync/room_lists.py Show resolved Hide resolved
@MadLittleMods MadLittleMods merged commit 4ac7835 into develop Sep 13, 2024
39 checks passed
@MadLittleMods MadLittleMods deleted the dbkr/sss_tags branch September 13, 2024 01:18
@MadLittleMods
Copy link
Contributor

Thanks for the quick review @devonh 🦒

@dbkr Thanks for getting this going making Sliding Sync more compatible with Element Web! 🦃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadLittleMods MadLittleMods MadLittleMods approved these changes

@devonh devonh devonh approved these changes

Assignees
No one assigned
Labels
A-Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbkr @MadLittleMods @devonh