Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sliding Sync: Add comment to explain extra case where you can be invited -> banned -> unbanned #17654

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Sliding Sync: Add comment to explain extra case where you can be invited -> banned -> unbanned #17654

merged 4 commits into from
Sep 9, 2024

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Sep 3, 2024 •
edited
Loading

Add comment to explain extra case where you can be invited -> banned -> unbanned and we want to be able to find the invite event.

Follow-up to #17636 (comment)

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@MadLittleMods MadLittleMods mentioned this pull request Sep 3, 2024
Merged
@MadLittleMods MadLittleMods marked this pull request as ready for review September 3, 2024 22:45
@MadLittleMods MadLittleMods requested a review from a team as a code owner September 3, 2024 22:45
@MadLittleMods MadLittleMods merged commit 515c1cc into develop Sep 9, 2024
39 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/sliding-sync-note-previous-membership-case branch September 9, 2024 22:56
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @erikjohnston 🦇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
A-Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MadLittleMods @erikjohnston