Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unique name for each os.arch variant when uploading Wheels #17905

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Use unique name for each os.arch variant when uploading Wheels #17905

merged 2 commits into from
Nov 6, 2024

Conversation

devonh
Copy link
Member

@devonh devonh commented Nov 6, 2024

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@devonh devonh requested a review from a team as a code owner November 6, 2024 05:33
@devonh devonh merged commit 61aadb1 into develop Nov 6, 2024
31 checks passed
@devonh devonh deleted the devon/upload-artifact branch November 6, 2024 15:21
@erikjohnston erikjohnston mentioned this pull request Nov 11, 2024
Merged
erikjohnston added a commit that referenced this pull request Nov 11, 2024
@erikjohnston
Fix building and attaching release artifacts (#17921)
2637b26 
Broke in #17905 due to upgrading the `upload-artifact` action, as we
didn't rename debs. I think we also need to change how we download the
artefacts and attach them to a release, as they'll download to a
different place.

Docs:
- https://github.com/actions/upload-artifact/tree/v4/
- https://github.com/actions/download-artifact/tree/v4/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reivilibre reivilibre reivilibre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devonh @reivilibre