Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

RTL marks in displaynames affect following text #270

Open
matrixbot opened this issue Jul 1, 2016 · 3 comments
Open

RTL marks in displaynames affect following text #270

matrixbot opened this issue Jul 1, 2016 · 3 comments

Comments

@matrixbot
Copy link

Created by @ richvdh:sw1v.org.

as per element-hq/element-web#1712

@ylecollen
Copy link
Contributor

@SafaAlfulaij
Copy link
Contributor

I'm not sure if I understand this :)

I've used FSI and PDI around name placeholders while translating, so that the name is displayed correctly however it was written.

If you make that internal you'll make my life a bit eaiser and this will work also for English locale with Arabic names having strange marks like _[].- etc...

And of course you'll need to add some LRM chars to force the direction of the sentence.
So for example, "USER1 kicked USER2" will be like "(LRM)USER1 kicked USER2", where USER1 is "(FSI)USER1(PDI)" and USER2 is "(FSI)USER2(PDI)".

If copying text is allowed, and you don't want these text (for some reason), you can always trim cut the first and last chars.

And by the way, the RTL layout is still being displayed as #749.
The settings are correctly mirrored, since they are using standard Android stuff.

Thanks for the great work 👍

@SafaAlfulaij
Copy link
Contributor

English UI:
screenshot_2018-07-16-17-47-52
Arabic UI (with the marks I mentioned):
screenshot_2018-07-16-17-49-03
Of course this is RTL text, but as you see the new display name is displayed correctly. The old one is after the first word on the second line and before the second (invisible mark).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants