Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues after adding sticky headers #947

Closed
bwindels opened this issue Dec 9, 2022 · 0 comments · Fixed by #965
Closed

Fix some issues after adding sticky headers #947

bwindels opened this issue Dec 9, 2022 · 0 comments · Fixed by #965
Assignees

Comments

@bwindels
Copy link
Contributor

bwindels commented Dec 9, 2022

  • remove debug logging saying formatRelativeDate
  • GapTile.notifyVisible doesn't seem to be called anymore when the viewport isn't filled after opening the timeline. The symptom of this is that at the top of the timeline it says "Not loading" and indeed scrolling doesn't trigger the timeline to be loaded any further. I've checked that programmatically calling notifyVisible on the GapTile from the console loads the timeline again. This is a critical issue, as there is no workaround to access earlier history.
  • need to update relative dates after midnight otherwise today is labeled as tomorrow if you leave your client open until the next day
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant