Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message with msgtype = m.notice renders like regular message #3636

Open
bmarty opened this issue Oct 9, 2024 · 2 comments
Open

Message with msgtype = m.notice renders like regular message #3636

bmarty opened this issue Oct 9, 2024 · 2 comments
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Design

Comments

@bmarty
Copy link
Member

bmarty commented Oct 9, 2024

Steps to reproduce

  1. observe how a m.notice message is rendered in a timeline

Outcome

What did you expect?

It should render differently than regular messages.

What happened instead?

m.notice are rendered as regular messages.

Note: EX iOS is rendering a info picto on the left of the message, but I can't find any design about this. Element Web is rendering m.notice using secondary text color. @amshakal can you help please?

Your phone model

any

Operating system version

any

Application version and app store

all

Homeserver

any

Will you send logs?

No

Are you willing to provide a PR?

Yes

@bmarty bmarty added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 9, 2024
@manuroe
Copy link
Member

manuroe commented Oct 9, 2024

EXI has it since the very beginning. I am not sure if we followed a design. @stefanceriu do you remember?

It is how it currently looks like on iOS:
image

@stefanceriu
Copy link
Member

EXI has it since the very beginning. I am not sure if we followed a design. @stefanceriu do you remember?

The layout is pretty much the same since the beginning and we tweaked the icon a while back https://github.com/element-hq/element-x-ios/pull/2120/files#diff-20891962bb851e50bf0321b0732a4ccc28a1664119872e35bc2d37d037ce407f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Design
Projects
None yet
Development

No branches or pull requests

3 participants