Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User colors #1227

Open
bmarty opened this issue Sep 5, 2023 · 8 comments
Open

User colors #1227

bmarty opened this issue Sep 5, 2023 · 8 comments
Labels
A-Room List A-Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@bmarty
Copy link
Member

bmarty commented Sep 5, 2023

We now have 8 colors to be consistent with EXI and EleWeb, but Figma file has only 6 colors.

At some point this will have to be updated, with some synchronization with the other Element clients.

Also the same should apply to room avatar, with some specific rules about the id to use to compute the hash. If the room is a DM, we should use the otherId to compute the hash, instead of the roomId.

(algo on web: https://github.com/matrix-org/matrix-react-sdk/blob/c853257d54c2056bb2dd08ba5d3798300daaaf61/src/components/views/avatars/RoomAvatar.tsx#L119, but not very clear to me)

Note: for now we can only use the roomId to compute the hash.

Related #1224

@jmartinesp
Copy link
Member

jmartinesp commented Sep 5, 2023

The DM strategy is not possible at the moment, since we don't have any member info in the room list (only the user count). Once we have the heroes info coming from sliding sync, this could be implemented.

@pixlwave
Copy link
Member

pixlwave commented Sep 5, 2023

Related issue for the DMs: matrix-org/sliding-sync#241

@bmarty bmarty added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Room List A-Timeline labels Sep 5, 2023
@manuroe
Copy link
Member

manuroe commented Sep 13, 2023

We now have 8 colors to be consistent with EXI and EleWeb, but Figma file has only 6 colors.

@nadonomy, can you help to clarify this

@pixlwave
Copy link
Member

Related issue for the DMs: matrix-org/sliding-sync#241

The above has been merged, issue on Rust for tracking the integration into the SDK: matrix-org/matrix-rust-sdk#2702

@nadonomy
Copy link

We now have 8 colors to be consistent with EXI and EleWeb, but Figma file has only 6 colors.

@nadonomy, can you help to clarify this

Sorry missed this. @callumu @janogarcia @germain-gg any clues? We seem to have 6 in Figma, but then 8 in Storybook.

@germain-gg
Copy link
Contributor

It's probably me who kept the 8 colour we originally had and mapped them to the decorative colour scales.
We can remove the extra two that do not exist in Figma, or add the missing ones in Figma. I don't really have a strong opinion.

@callumu
Copy link

callumu commented Oct 25, 2023

I'm not sure why they're different, but they should match the 6 colours in the extended palette

@pixlwave
Copy link
Member

iirc, @Velin92, @germain-gg, @amshakal and myself took the decision on a call to use 8 colours on iOS for consistency in the colours shown between platforms (because web didn't have the time to change it before it landed on iOS). Then the same happened for Android. The plan was to move all the platforms to use the correct 6 colours when everyone was available to do it in sync so we didn't end up with one platform showning completely different colours to users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room List A-Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

7 participants