-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User colors #1227
Comments
The DM strategy is not possible at the moment, since we don't have any member info in the room list (only the user count). Once we have the heroes info coming from sliding sync, this could be implemented. |
Related issue for the DMs: matrix-org/sliding-sync#241 |
@nadonomy, can you help to clarify this |
The above has been merged, issue on Rust for tracking the integration into the SDK: matrix-org/matrix-rust-sdk#2702 |
Sorry missed this. @callumu @janogarcia @germain-gg any clues? We seem to have 6 in Figma, but then 8 in Storybook. |
It's probably me who kept the 8 colour we originally had and mapped them to the decorative colour scales. |
I'm not sure why they're different, but they should match the 6 colours in the extended palette |
iirc, @Velin92, @germain-gg, @amshakal and myself took the decision on a call to use 8 colours on iOS for consistency in the colours shown between platforms (because web didn't have the time to change it before it landed on iOS). Then the same happened for Android. The plan was to move all the platforms to use the correct 6 colours when everyone was available to do it in sync so we didn't end up with one platform showning completely different colours to users. |
We now have 8 colors to be consistent with EXI and EleWeb, but Figma file has only 6 colors.
At some point this will have to be updated, with some synchronization with the other Element clients.
Also the same should apply to room avatar, with some specific rules about the id to use to compute the hash. If the room is a DM, we should use the otherId to compute the hash, instead of the roomId.
(algo on web: https://github.com/matrix-org/matrix-react-sdk/blob/c853257d54c2056bb2dd08ba5d3798300daaaf61/src/components/views/avatars/RoomAvatar.tsx#L119, but not very clear to me)
Note: for now we can only use the roomId to compute the hash.
Related #1224
The text was updated successfully, but these errors were encountered: