Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing welcomeUserId doesn't disable matrix-bot button on welcome page #9263

Closed
killua-eu opened this issue Mar 23, 2019 · 5 comments
Closed

missing welcomeUserId doesn't disable matrix-bot button on welcome page #9263

killua-eu opened this issue Mar 23, 2019 · 5 comments
Labels
A-Welcome-Page P2 T-Defect

Comments

@killua-eu
Copy link

Description

With "welcomeUserId": "@riot-bot:matrix.org", removed from the config.js, the "Chat with the Riot Bot" button is still visible/actionable on https://chat.example.com/#/welcome. On servers with federation turned off, clicking the button leads unsuspecting users into an empty room.

Version information

  • Platform: web
  • Version: 1.0.5
@killua-eu killua-eu mentioned this issue Mar 23, 2019
Closed
@jaywink

This comment has been minimized.

Sign in to view
@jryans

This comment has been minimized.

Sign in to view
@jryans jryans mentioned this issue Apr 9, 2019
Closed
@jaywink

This comment has been minimized.

Sign in to view
@turt2live
Copy link
Member

fwiw the expectation in the implementation of the welcome page was originally that people would simply overwrite the HTML document with their own rather than it be dynamic content.

@turt2live
Copy link
Member

our default welcome page has removed the button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Welcome-Page P2 T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jryans @killua-eu @jaywink @turt2live @lampholder