Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riot doesn't follow 301 responses during homeserver discovery #9084

Closed
non-Jedi opened this issue Mar 7, 2019 · 6 comments
Closed

Riot doesn't follow 301 responses during homeserver discovery #9084

non-Jedi opened this issue Mar 7, 2019 · 6 comments
Labels
A-Login A-Registration P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@non-Jedi
Copy link

non-Jedi commented Mar 7, 2019

Description

When I enter in my mxid @adam:thebeckmeyers.xyz, Riot sends a request to https://thebeckmeyers.xyz/.well-known/matrix/client and gets back:

HTTP/2.0 301 Moved Permanently
content-length: 0
location: https://www.thebeckmeyers.xyz/.well-known/matrix/client
X-Firefox-Spdy: h2

It then fails to request the specified location and says "Invalid homeserver discovery response"

Steps to reproduce

Enter @adam:thebeckmeyers.xyz in the username field of Riot sign-in.

Version information

  • Platform: web

For the web app:

  • Browser: Firefox 65.0.1
  • OS: Void Linux
  • URL: riot.im/develop
@turt2live
Copy link
Member

fwiw, the spec is super strict in this respect and doesn't let us follow 301 redirects: https://matrix.org/docs/spec/client_server/r0.4.0.html#server-discovery

MSC1700 could probably be brought back to life, and take this into consideration. Have opened https://github.com/matrix-org/matrix-doc/issues/1919 to track this.

@non-Jedi
Copy link
Author

non-Jedi commented Mar 7, 2019

Ah. Not sure what the practice is on bugs on riot-web where a spec issue causes a Riot ux issue. Feel free to close this if that's the best way of handling.

@turt2live
Copy link
Member

riot-web is the dumping ground for UX of Matrix, still :(

@lampholder lampholder added T-Defect P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Registration A-Login labels Mar 15, 2019
@turt2live turt2live self-assigned this May 14, 2019
@turt2live turt2live removed their assignment Jul 11, 2019
@hex-m
Copy link

hex-m commented Jun 9, 2020

MSC2499 would clarify this.

@tulir
Copy link
Contributor

tulir commented Aug 19, 2020

Element already follows redirects, but https://thebeckmeyers.xyz/.well-known/matrix/client is missing CORS headers.

@turt2live
Copy link
Member

Overall this issue isn't one of Element (if anything it shouldn't follow the redirect), but of the spec: https://github.com/matrix-org/matrix-doc/issues/1919

Closing in favour of the spec issue. In general I think we should continue to follow the redirect and work on making the spec sensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Login A-Registration P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

5 participants