Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML messages #86

Closed
ara4n opened this issue Aug 30, 2015 · 8 comments
Closed

HTML messages #86

ara4n opened this issue Aug 30, 2015 · 8 comments

Comments

@ara4n
Copy link
Member

ara4n commented Aug 30, 2015

No description provided.

@ara4n ara4n added the feature label Aug 30, 2015
@dbkr
Copy link
Member

dbkr commented Sep 7, 2015

There is no Matrix standard for HTML messages currently, apart from the matrix.org custom one. We would need a standard one (or implement a Vector one but this would be contrary to the whole ethos of Matrix).

@ara4n ara4n added P2 and removed feature labels Sep 7, 2015
@ara4n
Copy link
Member Author

ara4n commented Sep 7, 2015

Suggest we just use the matrix.org custom one for now

On 7 Sep 2015, at 18:20, David Baker [email protected] wrote:

There is no Matrix standard for HTML messages currently, apart from the matrix.org custom one. We would need a standard one (or implement a Vector one but this would be contrary to the whole ethos of Matrix).


Reply to this email directly or view it on GitHub.

@ara4n ara4n added the feature label Sep 7, 2015
@dbkr
Copy link
Member

dbkr commented Sep 7, 2015

I'd vote fairly strongly that we bite the bullet and get this specified now rather than make the problem worse still.

@ara4n
Copy link
Member Author

ara4n commented Sep 7, 2015

Okay. Starting point would be whether React gives a nice HTML or CSS
sanitiser we can use as an 'implementation is the reference' starting
point.

Failing that, we'll be faffing around specifying a manual whitelist of
HTML tags and attributes and optionally CSS styles... or using MD or RST
or whatever as an intermediate representation and needing to render it in
the client.

On Mon, 7 Sep 2015, David Baker wrote:

I'd vote fairly strongly that we bite the bullet and get this specified now rather than make the
problem worse still.


Reply to this email directly or view it on
GitHub.[ABO_vSYCKQjGR5MhHDqx4_6A74iJxMh2ks5ovdVggaJpZM4F0lpq.gif]

@dbkr
Copy link
Member

dbkr commented Sep 7, 2015

@ara4n
Copy link
Member Author

ara4n commented Oct 30, 2015

given the spec stuff isn't progressing and I want this feature right now, I've implemented the org.matrix one for now in fdfa0cb

@ara4n ara4n closed this as completed Oct 30, 2015
@ara4n
Copy link
Member Author

ara4n commented Oct 30, 2015

(obviously I am very happy for the impl to be replaced once matrix-org/matrix-spec-proposals#92 is sorted out and lands)

@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015
@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Sep 24, 2024

t3chguy pushed a commit that referenced this issue Oct 17, 2024
* CryptographyPanel: fix display of device key

* CryptographPanel: Fix HTML nesting

you're not supposed to put <tr> directly inside <table>; doing so causes
warnings.

* Update tests
JohnSimonsen pushed a commit to verji/element-web-v2 that referenced this issue Dec 20, 2024
* 1991, 1992 hide labs and link dm invite

* 1991, 1992 hide labs and link dm invite

* 1991, 1992 hide labs and link dm invite

* 1994 Help about, bugreporting

* 1942 Verji changes, part 3

* Added translattion after merge conflict

* Fixed error in file

* English translation

* Fixed lint errors

* Fixed lint errors

* error fixing for pr eik/hide_labs_and_sharedinvites

* Added freshworks.js to eslintignore

* Fixex pipeline errors

* update snapshot

* Fixex pipeline errors

* Fixex pipeline errors

* update snapshot

---------

Co-authored-by: John Tore Simonsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants