Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental: Lots of text is not readable due to too low contrast between foreground and background #7946

Closed
fladd opened this issue Dec 23, 2018 · 8 comments

Comments

@fladd
Copy link

fladd commented Dec 23, 2018

  • Left pane: Rooms with new messages are not distinguishable from rooms with no new messages
  • Middle pane:
    • Top: Room description is not readable
    • Center: Dates, timestamps, join/leave messages are not readable
    • Bottom: Encryption status, message in the entry field are not readable
  • Right pane:
    • Member list: Online/offline state, message in filter box are not readable
    • File list: Timestamps, filesize are not readable
    • Notifications: Dates are not readable
@fladd
Copy link
Author

fladd commented Dec 23, 2018

This is about the redesign (on experimental branch). I was brought here from within the experimental branch to give feedback about the redesign, but it appears that the issue is not tagged correctly (and I also cannot tag it myself apparently).

@turt2live turt2live changed the title Lots of text is not readable due to too low contrast between foreground and background Experimental: Lots of text is not readable due to too low contrast between foreground and background Dec 23, 2018
@ara4n ara4n added the redesign label Dec 27, 2018
@jryans
Copy link
Collaborator

jryans commented Dec 29, 2018

@fladd, could you include a screenshot as well? Some users have been seeing different fonts than expected, so it's good to have visual confirmation of what you are seeing on your side.

@ghost
Copy link

ghost commented Dec 29, 2018

What theme? Can't reproduce this on any of them, I can read all the text.

@jryans
Copy link
Collaborator

jryans commented Dec 31, 2018

What theme? Can't reproduce this on any of them, I can read all the text.

Since this is a redesign issue, I am assuming the reporter is talking about the theme on riot.im/experimental. (There is only one theme currently available there.)

@lampholder
Copy link
Member

WCAG contrast checker (set to AA) flags issues with:

  • hyperlinks
  • timestamps
  • room topic text
  • some of the display name colours
  • the 'Invite to this room' white on green button in the member list panel

Everything else is fine (explicitly: timeline text, member list, room list, avatars, room title).

It looks to me like the ff WCAG plugin doesn't check for visibility of placeholder text, 'cause the placeholder in the room- and memberlist-filters looks very low contrast to me.

@fladd
Copy link
Author

fladd commented Jan 3, 2019

Yes, I am talking about the experimental theme. And yes, I can also read the text, if I am squinting closely at my screen. But why would you want users to do this? Shouldn't they be able to use the app comfortably? Especially if it can easily be fixed so easily by just increasing the contrast (and in case of room names with unread messages in the room list by giving it a different colour than the rooms with no unread messages)?

@AndrewJDR
Copy link
Contributor

Particularly the "Online/offline state" not being visible in the member list anymore is an annoyance. It's a pretty common thing to glance over at that status to know whether it's worth contacting someone at the moment.

@nadonomy
Copy link
Contributor

Closing this as >2 years old, themes have changed dramatically since. :)

If needed, please open new issue(s) with screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants