Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"call ended" events cause an unread notification in the systray although all messages in the room have been read #7941

Closed
MazeChaZer opened this issue Dec 21, 2018 · 7 comments
Labels
A-Notifications A-VoIP Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@MazeChaZer
Copy link

MazeChaZer commented Dec 21, 2018

Description

If the last event in a room is a "call ended" event, there is an unread notification in the systray icon that won't go away until other events are received and read in that room.

Steps to reproduce

  • Make a one-to-one call
  • Hang up

I expect: No unread notification
Actual: Unread notificatin in systray icon

Log: Sent

Version information

  • Platform: Desktop
  • OS: Windows, Arch Linux
  • Version: 0.17.8

Possibly related: #6617

@lampholder
Copy link
Member

We have multiple instances of this - how tractable is it to knock non-message events counting towards unread state/message counts/whatever on the head once and for all?

@lampholder lampholder added T-Defect P1 S-Minor Impairs non-critical functionality or suitable workarounds exist A-Notifications labels Jan 2, 2019
@hughwilliams94
Copy link

For what it is worth, I think this affects all platforms not just the web client. On my girlfriends iPhone, there are notification badges which cannot be cleared.

@msrd0
Copy link

msrd0 commented Jun 20, 2019

Can confirm that this affects multiple platforms. Can reproduce with Riot 1.2.1 on Firefox and Electron on ArchLinux, as well as 0.8.28a on Android installed via F-Droid.

@Thatoo
Copy link

Thatoo commented May 3, 2020

Yes, it affects Riot Desktop on Ubuntu and Riot on Android 6.0 at least.

@afranke afranke added the A-VoIP label Aug 25, 2021
@SimonBrandner SimonBrandner added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed P1 labels Dec 5, 2021
@SimonBrandner
Copy link
Contributor

The only proper solution here is to use to-device messages as proposed by matrix-org/matrix-spec-proposals#3401

@HarHarLinks
Copy link
Contributor

Maybe this, but maybe not quite?

Steps to reproduce

  1. get called 1:1 e2ee while offline/only online on E android
  2. press phone's standby button to silence ringing
  3. start E desktop to see notification count of 5 (on the room in the room list)

Outcome

Really this should count as 1 if there is only 1 event in the timeline (the call thingy in missed call state).

I wonder if it should be a "ping" event (red) or something else.


However I don't have a problem with "stuck" notifications badges in either systray nor room list. The confusing part about this is that you expect to see 5 unread messages, that is the call plus 4 before that, however there are not 4.

@turt2live
Copy link
Member

Closing in favour of element-hq/element-meta#1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-VoIP Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

10 participants