Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.15.2 and 0.15.3 of riot-web: Encryption not working any longer, earlier encrypted rooms become undecryptable #6761

Closed
chrissi55 opened this issue May 18, 2018 · 31 comments
Labels
A-E2EE P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@chrissi55
Copy link

chrissi55 commented May 18, 2018

Description

After Upgrading my Version of riot-web: to 0.15.2 all e2e encrypted chats are undecryptable.
Program says - enforce resending keys again but when key pulling is enforced nothing happened.

Exporting and Importing Keys of another (Android) Client will re-enable all posts till point of export.

But newly send messages are again encrypted for the Linux Client.

All my devices where accepted by riot.

Steps to reproduce

  • For bugs, list the steps
  • that reproduce the bug
  • using hyphens as bullet points

Describe how what happens differs from what you expected.

@dbkr Log: How to extract the errorlogfile? I can't find the log under /var/log/... nor /opt/riot/.... please give me a hint

Version information

  • Platform: desktop!

For the web app:

  • Browser: no webapp -> desktop
  • OS: Linux
  • URL: riot.im/develop / riot.im/app / somewhere else? If a private server, what version of riot-web?

For the desktop app:

  • OS: Linux, Zorin OS (ubuntu)?
  • Version: riot 0.15.2, Zorin 12.3

Update:
I cleared the Cache and reboot ... no difference, chat stays encrypted

@dbkr
Copy link
Member

dbkr commented May 18, 2018

Can you fill in the rest of the fields in the bug report please? Most importantly, sent log files from both the sender and receiver.

@akontsevich
Copy link

akontsevich commented May 18, 2018

I have same issue: now can't access messages at all on any device with 0.14 or 0.15.2 versions, both: desktop and web version in any browser. Terrible: now I can't read the room where I'm an administrator. I suggested people to use Riot now will be forced to close this room and create new one. Need to test better before release to public! Now it is totally unusable!

OS: Linux openSUSE
Browser: FF, Chrome

@chrissi55 chrissi55 changed the title Version von riot-web: 0.15.2 Encryption not working any longer Version 0.15.2 of riot-web: Encryption not working any longer, earlier encrypted rooms become undecryptable May 19, 2018
@chrissi55
Copy link
Author

chrissi55 commented May 19, 2018

I did some more tests ....

Created a new Room with linux desktop app 0.15.2
Started e2e encryption and invited someone

Invite has been accepted and messages sent were signed with a green lock.
On side of the receiver every message is marked as

"** Unable to decrypt: The sender's device has not sent us the keys for this message. **
Verschlüsselungs-Schlüssel von deinen anderen Geräten erneut anfragen.?"

So the problem exists not only for earlier created e2e encrypted rooms but also for newly created ones.
Something must be broken by e2e encryption.

Opening the details of the encrypted room and clicking on the device list of a member offers "all deveices are accepted"

Rooms with no e2e are working as expected.

@chrissi55
Copy link
Author

Somebody should tag this problem as bug or maybe critical before other users upgrade their desktop app and run into same desaster!

@ara4n
Copy link
Member

ara4n commented May 19, 2018

we have only heard about this from two people, and haven’t seen any logs to debug (please submit them via the Submit Logs button in User Settings), so we’re still trying to assess how bad the situation is.

Have you been trying to switch back and forth between 0.14 and 0.15 desktop apps?

@ara4n
Copy link
Member

ara4n commented May 19, 2018

(i'm going to delete the "why don't we completely change Matrix's encryption model" comments, as they're irrelevant and distracting to this bug - feel free to open a separate spec bug over at matrix-org/matrix-doc if you like)

@element-hq element-hq deleted a comment from akontsevich May 19, 2018
@element-hq element-hq deleted a comment from t3chguy May 19, 2018
@element-hq element-hq deleted a comment from akontsevich May 19, 2018
@element-hq element-hq deleted a comment from t3chguy May 19, 2018
@element-hq element-hq deleted a comment from akontsevich May 19, 2018
@element-hq element-hq deleted a comment from t3chguy May 19, 2018
@element-hq element-hq deleted a comment from akontsevich May 19, 2018
@element-hq element-hq deleted a comment from t3chguy May 19, 2018
@element-hq element-hq deleted a comment from akontsevich May 19, 2018
@chrissi55
Copy link
Author

chrissi55 commented May 20, 2018

Hi ara4n, as i've written above

"...@dbkr Log: How to extract the errorlogfile? I can't find the log under /var/log/... nor /opt/riot/.... please give me a hint ...."

But till now no hints where given ... so again please give me a hint, how can i find the logs you're looking for.

I want to see a preview of the logs i will send via riot before i sent them via internet
As riot desktop app "says" - Log will sent usernames, room-id, etc etc. that data i will check before spreading them .... comprehensible i think :-)

But you are right I will do anything that helps to find the bug 👍

@chrissi55 chrissi55 changed the title Version 0.15.2 of riot-web: Encryption not working any longer, earlier encrypted rooms become undecryptable Version 0.15.2 and 0.15.3 of riot-web: Encryption not working any longer, earlier encrypted rooms become undecryptable May 20, 2018
@ptman
Copy link
Contributor

ptman commented May 20, 2018

From the "New issue" template:

You can send us the app's logs via the 'Report bug'
link on the 'Settings' page. Very important for hard-to-reproduce bugs. Please
file a bug here too!

@chrissi55
Copy link
Author

Log transmitted via link -> #6761

@akontsevich
Copy link

Have you been trying to switch back and forth between 0.14 and 0.15 desktop apps?

As I have mentioned above - yes, switched back to 0.14 - keys still lost, and in web version (I have not cleaned up cache, cookies or something) too for some reason. So it is lost everywhere and can't restore conversation. When switching back from 15 to 14 credentials are lost too: need to enter login, pass again.

@akontsevich
Copy link

You can send us the app's logs via the 'Report bug' link on the 'Settings' page.

I do not see any 'Report bug' link there. Is it exist in 0.14?

@chrissi55
Copy link
Author

chrissi55 commented May 21, 2018

@akontsevich
if i'm right ...
in the riot desktop / web-app go to the settings (main settings) and scroll down until the E2E Encryption Keys export / import. Underneath that export / import buttons you should see another button for error reporting.
Insert the GitHub URL of this issue
-> #6761

and you should be able to send a logfile

What i dislike here is the fact, that a user can't preview it's logfile before (!) it is send
Not that kind of confidence base i prefer!

@dbkr
Copy link
Member

dbkr commented May 21, 2018

I have one log from this issue but I can't see anything in it that would cause problems. If anyone else is able to send logs, that would be great - see the issue template for how to do so. Logs from the sender side too would be ideal.

Edit: Also, don't switch between 0.14 and 0.15 desktop apps: chrome's database is not backwards compatible so you'll be logged out if you go back to 0.14.

@akontsevich
Copy link

in the riot desktop / web-app go to the settings (main settings) and scroll down until the E2E Encryption Keys export / import. Underneath that export / import buttons you should see another button for error reporting.

I do not have either in 0.14 or 0.15 desktop. Where are they located, how to get them and upload here manually. Also I see "Export room keys" button there. Where room keys are stored in Linux/Mac/Windows, how to load them manually? May be I can find them on this PC or another?

@dbkr
Copy link
Member

dbkr commented May 21, 2018

Just been chatting about this with PC-Admin in #riot:matrix.org. It looks like at some point the indexeddb data got deleted, resetting the device key. I don't yet know what caused this.

Logging out and logging back in again (a third time...) made things work again, so this is a workaround if you have keys from another device you can import and export

@akontsevich
Copy link

akontsevich commented May 21, 2018

Logging out and logging back in again (a third time...) made things work again, so this is a workaround if you have keys from another device you can import and export

Where this keys are stored?! Path?! Linux/Mac/Windows? And what is passphrase - my password?

@dbkr
Copy link
Member

dbkr commented May 21, 2018

@akontsevich this one of the settings you seem to be missing somehow - I'd suggest dropping into #riot:matrix.org and someone can help figure out why you can't find these.

@akontsevich
Copy link

@dbkr You are developer? You do not know? :)

@dbkr
Copy link
Member

dbkr commented May 21, 2018

Let's keep this for actual discussion on the bug itself please, rather than help with finding settings.

@akontsevich
Copy link

strange answer to me...

@akontsevich
Copy link

@dbkr according to #riot:matrix.org history many users have this bug and unable to continue working with Riot. And people can't get desktop Riot to work. I can't web version as well. So think no help there.

@akontsevich
Copy link

Hmm... I found this text in desktop version when trying to relogin:

Sign out
For security, logging out will delete any end-to-end encryption keys from this browser. If you want to be able to decrypt your conversation history from future Riot sessions, please export your room keys for safe-keeping.

So seems after upgrading Riot signouts somehow and cleared all the keys. So I need always save all the keys from all rooms on every sign out? And watch for them manually all the time? What a stupid an inconvenient behaviour.

@chrissi55
Copy link
Author

chrissi55 commented May 21, 2018

Just been chatting about this with PC-Admin in #riot:matrix.org. It looks like at some point the indexeddb data got deleted, resetting the device key. I don't yet know what caused this.

So, there is a bug, that could be reproduced? I think so ...

Logging out and logging back in again (a third time...) made things work again, so this is a workaround if you have keys from another device you can import and export

Wouldn't that cause a new device key? And does that mean, that in the e2e chat my logged out and re-logged in device become "unknown" with yellow breakdown triangle?
I would wait until there might be another solution...

Exporting the keys / room keys is not the problem!
One export for all rooms is doing the job well but for now a little bit annoying :-)

If i'm right only the Linux desktop app causes this problem? Under Windows i think everything stays decryptable. Behaviour as expected ...

@akontsevich
Copy link

Bad you've left 0.15.2 version in web - logged-in Windows now (web version) - same issue. I've shared keys with other devices but messages still encrypted. So it is broken everywhere.

@chrissi55
Copy link
Author

chrissi55 commented May 21, 2018

Windows now (web version) - same issue. I've shared keys with other devices but messages still encrypted. So it is broken everywhere.

That are bad news! So i hope that the admins here could reproduce the bug as it is and mark this issue as "issue" so that others don't run into the same trap ....

I think we could say that we don't have an individual case.

@akontsevich you should be able to send a logfile (errorlog) from your Windows client maybe?
More infos could help the developers i hope....

@akontsevich
Copy link

@akontsevich you should be able to send a logfile (errorlog) from your Windows client maybe?

I've sent them from Windows machine - only web version have the button, so do not think it will help much.

@thomas-profitt
Copy link

I'm having what sounds like the same issue.

I'm in 2 E2E rooms, both 1:1, both with the same person, on Riot Web and Riot Android.

All messages in both rooms, whether they were from me on Riot Web, the other user on Riot Desktop (Windows), or either of us on Riot Android, began show as "unable to decrypt" in Riot Web for me, but continue to show normally for me on Riot Android (and presumably for the other user's clients). When I click "Re-request encryption keys" in my Riot Web, nothing happens.

I clicked my name in the member list on Riot Web and looked at devices: my mobile shows as verified, with correct device ID. I did the same in Riot Android, and my Riot Web shows as verified with the correct ID. All proper.

Clearing my cache in Riot Web did not affect it.

I sent a message from Riot Web, and here's its E2E info modal from Riot Web (where it was sent and has a 🔒 icon) and Riot Android (where it is displayed, but has a ⚠ icon instead):
screenshot from 2018-05-28 13-35-48

@thomas-profitt
Copy link

I created a new E2E empty room via Riot Android and messages show as unable to decrypt on Riot Web.

@akontsevich
Copy link

I think bug somewhere in settings saving: I switched notifications off because of electron bug, on next start they are switched on as by default. Some other settings returned to default values as well.

@thomas-profitt
Copy link

Something else that may help: I'm using Firefox, and I haven't logged in with this session in any other browsers or in Electron.

@lampholder lampholder added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-E2EE labels May 30, 2018
@richvdh
Copy link
Member

richvdh commented Jun 20, 2018

Just been chatting about this with PC-Admin in #riot:matrix.org. It looks like at some point the indexeddb data got deleted, resetting the device key. I don't yet know what caused this.

It feels like we should close this as a duplicate of the more specific and clearer #6808.

People should be aware this is far from the only cause of "unable to decrypt" errors. #2996 is a more general bug which tries to keep track of the various reasons for it.

@richvdh richvdh closed this as completed Jun 20, 2018
refi64 added a commit to refi64/riot-web-lc that referenced this issue Sep 28, 2021
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#19037](element-hq#19037)). Fixes element-hq#18481 and undefined/element-web#18481.
* Say Joining space instead of Joining room where we know its a space ([\element-hq#6818](matrix-org/matrix-react-sdk#6818)). Fixes element-hq#19064 and element-hq#19064.
* Add warning that some spaces may not be relinked to the newly upgraded room ([\element-hq#6805](matrix-org/matrix-react-sdk#6805)). Fixes element-hq#18858 and element-hq#18858.
* Delabs Spaces, iterate some copy and move communities/space toggle to preferences ([\element-hq#6594](matrix-org/matrix-react-sdk#6594)). Fixes element-hq#18088, element-hq#18524 element-hq#18088 and element-hq#18088.
* Show "Message" in the user info panel instead of "Start chat" ([\element-hq#6319](matrix-org/matrix-react-sdk#6319)). Fixes element-hq#17877 and element-hq#17877. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#6804](matrix-org/matrix-react-sdk#6804)).
* Replace plain text emoji at the end of a line ([\element-hq#6784](matrix-org/matrix-react-sdk#6784)). Fixes element-hq#18833 and element-hq#18833. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Simplify Space Panel layout and fix some edge cases ([\element-hq#6800](matrix-org/matrix-react-sdk#6800)). Fixes element-hq#18694 and element-hq#18694.
* Show unsent message warning on Space Panel buttons ([\#6778](matrix-org/matrix-react-sdk#6778)). Fixes element-hq#18891 and element-hq#18891.
* Hide mute/unmute button in UserInfo for Spaces as it makes no sense ([\element-hq#6790](matrix-org/matrix-react-sdk#6790)). Fixes element-hq#19007 and element-hq#19007.
* Fix automatic field population in space create menu not validating ([\element-hq#6792](matrix-org/matrix-react-sdk#6792)). Fixes element-hq#19005 and element-hq#19005.
* Optimize input label transition on focus ([\#6783](matrix-org/matrix-react-sdk#6783)). Fixes element-hq#12876 and element-hq#12876. Contributed by [MadLittleMods](https://github.com/MadLittleMods).
* Adapt and re-use the RolesRoomSettingsTab for Spaces ([\element-hq#6779](matrix-org/matrix-react-sdk#6779)). Fixes element-hq#18908 element-hq#18909 and element-hq#18908.
* Deduplicate join rule management between rooms and spaces ([\element-hq#6724](matrix-org/matrix-react-sdk#6724)). Fixes element-hq#18798 and element-hq#18798.
* Add config option to turn on in-room event sending timing metrics ([\element-hq#6766](matrix-org/matrix-react-sdk#6766)).
* Improve the upgrade for restricted user experience ([\element-hq#6764](matrix-org/matrix-react-sdk#6764)). Fixes element-hq#18677 and element-hq#18677.
* Improve tooltips on space quick actions and explore button ([\element-hq#6760](matrix-org/matrix-react-sdk#6760)). Fixes element-hq#18528 and element-hq#18528.
* Make space members and user info behave more expectedly ([\element-hq#6765](matrix-org/matrix-react-sdk#6765)). Fixes element-hq#17018 and element-hq#17018.
* hide no-op m.room.encryption events and better word param changes ([\element-hq#6747](matrix-org/matrix-react-sdk#6747)). Fixes element-hq#18597 and element-hq#18597.
* Respect m.space.parent relations if they hold valid permissions ([\element-hq#6746](matrix-org/matrix-react-sdk#6746)). Fixes element-hq#10935 and element-hq#10935.
* Space panel accessibility improvements ([\element-hq#6744](matrix-org/matrix-react-sdk#6744)). Fixes element-hq#18892 and element-hq#18892.
* Fix spacing for message composer buttons ([\element-hq#6854](matrix-org/matrix-react-sdk#6854)).
* Fix accessing field on oobData which may be undefined ([\element-hq#6830](matrix-org/matrix-react-sdk#6830)). Fixes element-hq#19085 and element-hq#19085.
* Fix reactions aria-label not being a string and thus being read as [Object object] ([\element-hq#6828](matrix-org/matrix-react-sdk#6828)).
* Fix missing null guard in space hierarchy pagination ([\element-hq#6821](matrix-org/matrix-react-sdk#6821)). Fixes matrix-org/element-web-rageshakes#6299 and matrix-org/element-web-rageshakes#6299.
* Fix checks to show prompt to start new chats ([\element-hq#6812](matrix-org/matrix-react-sdk#6812)).
* Fix room list scroll jumps ([\element-hq#6777](matrix-org/matrix-react-sdk#6777)). Fixes element-hq#17460 element-hq#18440 and element-hq#17460. Contributed by [robintown](https://github.com/robintown).
* Fix various message bubble alignment issues ([\element-hq#6785](matrix-org/matrix-react-sdk#6785)). Fixes element-hq#18293, element-hq#18294 element-hq#18305 and element-hq#18293. Contributed by [robintown](https://github.com/robintown).
* Make message bubble font size consistent ([\element-hq#6795](matrix-org/matrix-react-sdk#6795)). Contributed by [robintown](https://github.com/robintown).
* Fix edge cases around joining new room which does not belong to active space ([\#6797](matrix-org/matrix-react-sdk#6797)). Fixes element-hq#19025 and element-hq#19025.
* Fix edge case space issues around creation and initial view ([\#6798](matrix-org/matrix-react-sdk#6798)). Fixes element-hq#19023 and element-hq#19023.
* Stop spinner on space preview if the join fails ([\element-hq#6803](matrix-org/matrix-react-sdk#6803)). Fixes element-hq#19034 and element-hq#19034.
* Fix emoji picker and stickerpicker not appearing correctly when opened ([\#6793](matrix-org/matrix-react-sdk#6793)). Fixes element-hq#19012 and element-hq#19012. Contributed by [Palid](https://github.com/Palid).
* Fix autocomplete not having y-scroll ([\element-hq#6794](matrix-org/matrix-react-sdk#6794)). Fixes element-hq#18997 and element-hq#18997. Contributed by [Palid](https://github.com/Palid).
* Fix broken edge case with public space creation with no alias ([\element-hq#6791](matrix-org/matrix-react-sdk#6791)). Fixes element-hq#19003 and element-hq#19003.
* Redirect from /#/welcome to /#/home if already logged in ([\element-hq#6786](matrix-org/matrix-react-sdk#6786)). Fixes element-hq#18990 and element-hq#18990. Contributed by [aaronraimist](https://github.com/aaronraimist).
* Fix build issues from two conflicting PRs landing without merge conflict ([\element-hq#6780](matrix-org/matrix-react-sdk#6780)).
* Render guest settings only in public rooms/spaces ([\element-hq#6693](matrix-org/matrix-react-sdk#6693)). Fixes element-hq#18776 and element-hq#18776. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix message bubble corners being wrong in the presence of hidden events ([\element-hq#6776](matrix-org/matrix-react-sdk#6776)). Fixes element-hq#18124 and element-hq#18124. Contributed by [robintown](https://github.com/robintown).
* Debounce read marker update on scroll ([\element-hq#6771](matrix-org/matrix-react-sdk#6771)). Fixes element-hq#18961 and element-hq#18961.
* Use cursor:pointer on space panel buttons ([\element-hq#6770](matrix-org/matrix-react-sdk#6770)). Fixes element-hq#18951 and element-hq#18951.
* Fix regressed tab view buttons in space update toast ([\element-hq#6761](matrix-org/matrix-react-sdk#6761)). Fixes element-hq#18781 and element-hq#18781.
coolmic added a commit to livegen/riot-web that referenced this issue Oct 1, 2021
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#19037](element-hq#19037)). Fixes element-hq#18481 and undefined/element-web#18481.
* Say Joining space instead of Joining room where we know its a space ([\element-hq#6818](matrix-org/matrix-react-sdk#6818)). Fixes element-hq#19064 and element-hq#19064.
* Add warning that some spaces may not be relinked to the newly upgraded room ([\element-hq#6805](matrix-org/matrix-react-sdk#6805)). Fixes element-hq#18858 and element-hq#18858.
* Delabs Spaces, iterate some copy and move communities/space toggle to preferences ([\element-hq#6594](matrix-org/matrix-react-sdk#6594)). Fixes element-hq#18088, element-hq#18524 element-hq#18088 and element-hq#18088.
* Show "Message" in the user info panel instead of "Start chat" ([\element-hq#6319](matrix-org/matrix-react-sdk#6319)). Fixes element-hq#17877 and element-hq#17877. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#6804](matrix-org/matrix-react-sdk#6804)).
* Replace plain text emoji at the end of a line ([\element-hq#6784](matrix-org/matrix-react-sdk#6784)). Fixes element-hq#18833 and element-hq#18833. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Simplify Space Panel layout and fix some edge cases ([\element-hq#6800](matrix-org/matrix-react-sdk#6800)). Fixes element-hq#18694 and element-hq#18694.
* Show unsent message warning on Space Panel buttons ([\#6778](matrix-org/matrix-react-sdk#6778)). Fixes element-hq#18891 and element-hq#18891.
* Hide mute/unmute button in UserInfo for Spaces as it makes no sense ([\element-hq#6790](matrix-org/matrix-react-sdk#6790)). Fixes element-hq#19007 and element-hq#19007.
* Fix automatic field population in space create menu not validating ([\element-hq#6792](matrix-org/matrix-react-sdk#6792)). Fixes element-hq#19005 and element-hq#19005.
* Optimize input label transition on focus ([\#6783](matrix-org/matrix-react-sdk#6783)). Fixes element-hq#12876 and element-hq#12876. Contributed by [MadLittleMods](https://github.com/MadLittleMods).
* Adapt and re-use the RolesRoomSettingsTab for Spaces ([\element-hq#6779](matrix-org/matrix-react-sdk#6779)). Fixes element-hq#18908 element-hq#18909 and element-hq#18908.
* Deduplicate join rule management between rooms and spaces ([\element-hq#6724](matrix-org/matrix-react-sdk#6724)). Fixes element-hq#18798 and element-hq#18798.
* Add config option to turn on in-room event sending timing metrics ([\element-hq#6766](matrix-org/matrix-react-sdk#6766)).
* Improve the upgrade for restricted user experience ([\element-hq#6764](matrix-org/matrix-react-sdk#6764)). Fixes element-hq#18677 and element-hq#18677.
* Improve tooltips on space quick actions and explore button ([\element-hq#6760](matrix-org/matrix-react-sdk#6760)). Fixes element-hq#18528 and element-hq#18528.
* Make space members and user info behave more expectedly ([\element-hq#6765](matrix-org/matrix-react-sdk#6765)). Fixes element-hq#17018 and element-hq#17018.
* hide no-op m.room.encryption events and better word param changes ([\element-hq#6747](matrix-org/matrix-react-sdk#6747)). Fixes element-hq#18597 and element-hq#18597.
* Respect m.space.parent relations if they hold valid permissions ([\element-hq#6746](matrix-org/matrix-react-sdk#6746)). Fixes element-hq#10935 and element-hq#10935.
* Space panel accessibility improvements ([\element-hq#6744](matrix-org/matrix-react-sdk#6744)). Fixes element-hq#18892 and element-hq#18892.
* Fix spacing for message composer buttons ([\element-hq#6854](matrix-org/matrix-react-sdk#6854)).
* Fix accessing field on oobData which may be undefined ([\element-hq#6830](matrix-org/matrix-react-sdk#6830)). Fixes element-hq#19085 and element-hq#19085.
* Fix reactions aria-label not being a string and thus being read as [Object object] ([\element-hq#6828](matrix-org/matrix-react-sdk#6828)).
* Fix missing null guard in space hierarchy pagination ([\element-hq#6821](matrix-org/matrix-react-sdk#6821)). Fixes matrix-org/element-web-rageshakes#6299 and matrix-org/element-web-rageshakes#6299.
* Fix checks to show prompt to start new chats ([\element-hq#6812](matrix-org/matrix-react-sdk#6812)).
* Fix room list scroll jumps ([\element-hq#6777](matrix-org/matrix-react-sdk#6777)). Fixes element-hq#17460 element-hq#18440 and element-hq#17460. Contributed by [robintown](https://github.com/robintown).
* Fix various message bubble alignment issues ([\element-hq#6785](matrix-org/matrix-react-sdk#6785)). Fixes element-hq#18293, element-hq#18294 element-hq#18305 and element-hq#18293. Contributed by [robintown](https://github.com/robintown).
* Make message bubble font size consistent ([\element-hq#6795](matrix-org/matrix-react-sdk#6795)). Contributed by [robintown](https://github.com/robintown).
* Fix edge cases around joining new room which does not belong to active space ([\#6797](matrix-org/matrix-react-sdk#6797)). Fixes element-hq#19025 and element-hq#19025.
* Fix edge case space issues around creation and initial view ([\#6798](matrix-org/matrix-react-sdk#6798)). Fixes element-hq#19023 and element-hq#19023.
* Stop spinner on space preview if the join fails ([\element-hq#6803](matrix-org/matrix-react-sdk#6803)). Fixes element-hq#19034 and element-hq#19034.
* Fix emoji picker and stickerpicker not appearing correctly when opened ([\#6793](matrix-org/matrix-react-sdk#6793)). Fixes element-hq#19012 and element-hq#19012. Contributed by [Palid](https://github.com/Palid).
* Fix autocomplete not having y-scroll ([\element-hq#6794](matrix-org/matrix-react-sdk#6794)). Fixes element-hq#18997 and element-hq#18997. Contributed by [Palid](https://github.com/Palid).
* Fix broken edge case with public space creation with no alias ([\element-hq#6791](matrix-org/matrix-react-sdk#6791)). Fixes element-hq#19003 and element-hq#19003.
* Redirect from /#/welcome to /#/home if already logged in ([\element-hq#6786](matrix-org/matrix-react-sdk#6786)). Fixes element-hq#18990 and element-hq#18990. Contributed by [aaronraimist](https://github.com/aaronraimist).
* Fix build issues from two conflicting PRs landing without merge conflict ([\element-hq#6780](matrix-org/matrix-react-sdk#6780)).
* Render guest settings only in public rooms/spaces ([\element-hq#6693](matrix-org/matrix-react-sdk#6693)). Fixes element-hq#18776 and element-hq#18776. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix message bubble corners being wrong in the presence of hidden events ([\element-hq#6776](matrix-org/matrix-react-sdk#6776)). Fixes element-hq#18124 and element-hq#18124. Contributed by [robintown](https://github.com/robintown).
* Debounce read marker update on scroll ([\element-hq#6771](matrix-org/matrix-react-sdk#6771)). Fixes element-hq#18961 and element-hq#18961.
* Use cursor:pointer on space panel buttons ([\element-hq#6770](matrix-org/matrix-react-sdk#6770)). Fixes element-hq#18951 and element-hq#18951.
* Fix regressed tab view buttons in space update toast ([\element-hq#6761](matrix-org/matrix-react-sdk#6761)). Fixes element-hq#18781 and element-hq#18781.
BBaoVanC added a commit to boba-best/element.boba.best that referenced this issue Oct 2, 2021
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#19037](element-hq#19037)). Fixes element-hq#18481 and undefined/element-web#18481.
* Say Joining space instead of Joining room where we know its a space ([\element-hq#6818](matrix-org/matrix-react-sdk#6818)). Fixes element-hq#19064 and element-hq#19064.
* Add warning that some spaces may not be relinked to the newly upgraded room ([\element-hq#6805](matrix-org/matrix-react-sdk#6805)). Fixes element-hq#18858 and element-hq#18858.
* Delabs Spaces, iterate some copy and move communities/space toggle to preferences ([\element-hq#6594](matrix-org/matrix-react-sdk#6594)). Fixes element-hq#18088, element-hq#18524 element-hq#18088 and element-hq#18088.
* Show "Message" in the user info panel instead of "Start chat" ([\element-hq#6319](matrix-org/matrix-react-sdk#6319)). Fixes element-hq#17877 and element-hq#17877. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#6804](matrix-org/matrix-react-sdk#6804)).
* Replace plain text emoji at the end of a line ([\element-hq#6784](matrix-org/matrix-react-sdk#6784)). Fixes element-hq#18833 and element-hq#18833. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Simplify Space Panel layout and fix some edge cases ([\element-hq#6800](matrix-org/matrix-react-sdk#6800)). Fixes element-hq#18694 and element-hq#18694.
* Show unsent message warning on Space Panel buttons ([\#6778](matrix-org/matrix-react-sdk#6778)). Fixes element-hq#18891 and element-hq#18891.
* Hide mute/unmute button in UserInfo for Spaces as it makes no sense ([\element-hq#6790](matrix-org/matrix-react-sdk#6790)). Fixes element-hq#19007 and element-hq#19007.
* Fix automatic field population in space create menu not validating ([\element-hq#6792](matrix-org/matrix-react-sdk#6792)). Fixes element-hq#19005 and element-hq#19005.
* Optimize input label transition on focus ([\#6783](matrix-org/matrix-react-sdk#6783)). Fixes element-hq#12876 and element-hq#12876. Contributed by [MadLittleMods](https://github.com/MadLittleMods).
* Adapt and re-use the RolesRoomSettingsTab for Spaces ([\element-hq#6779](matrix-org/matrix-react-sdk#6779)). Fixes element-hq#18908 element-hq#18909 and element-hq#18908.
* Deduplicate join rule management between rooms and spaces ([\element-hq#6724](matrix-org/matrix-react-sdk#6724)). Fixes element-hq#18798 and element-hq#18798.
* Add config option to turn on in-room event sending timing metrics ([\element-hq#6766](matrix-org/matrix-react-sdk#6766)).
* Improve the upgrade for restricted user experience ([\element-hq#6764](matrix-org/matrix-react-sdk#6764)). Fixes element-hq#18677 and element-hq#18677.
* Improve tooltips on space quick actions and explore button ([\element-hq#6760](matrix-org/matrix-react-sdk#6760)). Fixes element-hq#18528 and element-hq#18528.
* Make space members and user info behave more expectedly ([\element-hq#6765](matrix-org/matrix-react-sdk#6765)). Fixes element-hq#17018 and element-hq#17018.
* hide no-op m.room.encryption events and better word param changes ([\element-hq#6747](matrix-org/matrix-react-sdk#6747)). Fixes element-hq#18597 and element-hq#18597.
* Respect m.space.parent relations if they hold valid permissions ([\element-hq#6746](matrix-org/matrix-react-sdk#6746)). Fixes element-hq#10935 and element-hq#10935.
* Space panel accessibility improvements ([\element-hq#6744](matrix-org/matrix-react-sdk#6744)). Fixes element-hq#18892 and element-hq#18892.
* Fix spacing for message composer buttons ([\element-hq#6854](matrix-org/matrix-react-sdk#6854)).
* Fix accessing field on oobData which may be undefined ([\element-hq#6830](matrix-org/matrix-react-sdk#6830)). Fixes element-hq#19085 and element-hq#19085.
* Fix reactions aria-label not being a string and thus being read as [Object object] ([\element-hq#6828](matrix-org/matrix-react-sdk#6828)).
* Fix missing null guard in space hierarchy pagination ([\element-hq#6821](matrix-org/matrix-react-sdk#6821)). Fixes matrix-org/element-web-rageshakes#6299 and matrix-org/element-web-rageshakes#6299.
* Fix checks to show prompt to start new chats ([\element-hq#6812](matrix-org/matrix-react-sdk#6812)).
* Fix room list scroll jumps ([\element-hq#6777](matrix-org/matrix-react-sdk#6777)). Fixes element-hq#17460 element-hq#18440 and element-hq#17460. Contributed by [robintown](https://github.com/robintown).
* Fix various message bubble alignment issues ([\element-hq#6785](matrix-org/matrix-react-sdk#6785)). Fixes element-hq#18293, element-hq#18294 element-hq#18305 and element-hq#18293. Contributed by [robintown](https://github.com/robintown).
* Make message bubble font size consistent ([\element-hq#6795](matrix-org/matrix-react-sdk#6795)). Contributed by [robintown](https://github.com/robintown).
* Fix edge cases around joining new room which does not belong to active space ([\#6797](matrix-org/matrix-react-sdk#6797)). Fixes element-hq#19025 and element-hq#19025.
* Fix edge case space issues around creation and initial view ([\#6798](matrix-org/matrix-react-sdk#6798)). Fixes element-hq#19023 and element-hq#19023.
* Stop spinner on space preview if the join fails ([\element-hq#6803](matrix-org/matrix-react-sdk#6803)). Fixes element-hq#19034 and element-hq#19034.
* Fix emoji picker and stickerpicker not appearing correctly when opened ([\#6793](matrix-org/matrix-react-sdk#6793)). Fixes element-hq#19012 and element-hq#19012. Contributed by [Palid](https://github.com/Palid).
* Fix autocomplete not having y-scroll ([\element-hq#6794](matrix-org/matrix-react-sdk#6794)). Fixes element-hq#18997 and element-hq#18997. Contributed by [Palid](https://github.com/Palid).
* Fix broken edge case with public space creation with no alias ([\element-hq#6791](matrix-org/matrix-react-sdk#6791)). Fixes element-hq#19003 and element-hq#19003.
* Redirect from /#/welcome to /#/home if already logged in ([\element-hq#6786](matrix-org/matrix-react-sdk#6786)). Fixes element-hq#18990 and element-hq#18990. Contributed by [aaronraimist](https://github.com/aaronraimist).
* Fix build issues from two conflicting PRs landing without merge conflict ([\element-hq#6780](matrix-org/matrix-react-sdk#6780)).
* Render guest settings only in public rooms/spaces ([\element-hq#6693](matrix-org/matrix-react-sdk#6693)). Fixes element-hq#18776 and element-hq#18776. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix message bubble corners being wrong in the presence of hidden events ([\element-hq#6776](matrix-org/matrix-react-sdk#6776)). Fixes element-hq#18124 and element-hq#18124. Contributed by [robintown](https://github.com/robintown).
* Debounce read marker update on scroll ([\element-hq#6771](matrix-org/matrix-react-sdk#6771)). Fixes element-hq#18961 and element-hq#18961.
* Use cursor:pointer on space panel buttons ([\element-hq#6770](matrix-org/matrix-react-sdk#6770)). Fixes element-hq#18951 and element-hq#18951.
* Fix regressed tab view buttons in space update toast ([\element-hq#6761](matrix-org/matrix-react-sdk#6761)). Fixes element-hq#18781 and element-hq#18781.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

8 participants