Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Download file" link in an encrypted room doesn't have a cursor #6058

Closed
turt2live opened this issue Jan 29, 2018 · 6 comments
Closed

"Download file" link in an encrypted room doesn't have a cursor #6058

turt2live opened this issue Jan 29, 2018 · 6 comments
Labels
P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Tolerable Low/no impact on users T-Defect

Comments

@turt2live
Copy link
Member

Description

The cursor should be a hand. This is a problem specific to encrypted rooms.

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 63
  • OS: Windows 10
  • URL: riot.im/develop
@t3chguy
Copy link
Member

t3chguy commented Jan 30, 2018

I cannot reproduce on the desktop app on windows, but also can't screenshot because snipping tools hide the cursor

@t3chguy
Copy link
Member

t3chguy commented Jan 30, 2018

also on Chrome 63 on Windows 10 on riot.im/develop

@t3chguy
Copy link
Member

t3chguy commented Jan 30, 2018

image

Had to revert to less sane methods

@t3chguy
Copy link
Member

t3chguy commented Jan 30, 2018

OH TIL E2E rooms have a Decrypt and then a Download, yeah I can repr
DERP
-_-

@t3chguy
Copy link
Member

t3chguy commented Jan 30, 2018

its because browsers getComputedStyle doesn't realise its a cursor

@t3chguy
Copy link
Member

t3chguy commented Jan 30, 2018

adding it to the CSS of the Decrypt link makes the browser realise and hey presto it passes it through to the iframe

This was referenced Jan 30, 2018
Merged
Merged
@lampholder lampholder added T-Defect ui/ux P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Tolerable Low/no impact on users labels Jan 31, 2018
@t3chguy t3chguy closed this as completed Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @lampholder @t3chguy