Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When composing rich replies, use a different popover on the message composer #5973

Closed
turt2live opened this issue Jan 11, 2018 · 5 comments
Closed
Labels
A-Replies reply P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect

Comments

@turt2live
Copy link
Member

Description

The current one looks too much like the autocomplete, implying that these things can be autocompleted. Some CSS to make it appear different would probably improve usability. I'd also recommend removing the message hover effect in that window.

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 63
  • OS: Windows 10
  • URL: riot.im/develop
@lampholder
Copy link
Member

I agree with removing the message hover effect (the highlight when I mouse over the message body of the message we're replying to) - it feels out of place in the reply to popover.

I don't get the same sense of autocompleting or autocompletability, but I'd be interested to hear what other people think.

@lampholder lampholder added T-Defect ui/ux P2 S-Minor Impairs non-critical functionality or suitable workarounds exist A-Replies reply S-Tolerable Low/no impact on users labels Jan 16, 2018
@t3chguy
Copy link
Member

t3chguy commented Jan 22, 2018

I'd also recommend removing the message hover effect in that window.

Fixed by #6017

@t3chguy
Copy link
Member

t3chguy commented Jan 30, 2018

Related to #5997

@yannicka
Copy link

I'm not sure I understand the problem. Is it possible to elaborate it?

@SimonBrandner
Copy link
Contributor

I believe this is no longer relevant, so I am going to close it. Shout if you disagree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Replies reply P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

6 participants