Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disambiguation algorithm should ignore whitespace #5827

Closed
pafcu opened this issue Dec 12, 2017 · 4 comments
Closed

Disambiguation algorithm should ignore whitespace #5827

pafcu opened this issue Dec 12, 2017 · 4 comments
Labels
Help Wanted Extra attention is needed P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround Security T-Defect

Comments

@pafcu
Copy link
Contributor

pafcu commented Dec 12, 2017 •
edited by t3chguy
Loading

Description

Currently it is possible to impersonate someone by using the same display name as they, but adding e.g. a space or zero-width space to your display name. This causes the disambiguation algorithm to think that there is no need to show the full mxid, even though it is impossible for a human to tell the two names apart.

Steps to reproduce

  • Have a user change their display name "testuser"
  • Have another user change their display name to "testuser "
  • Observe that messages from both users look identical

Version information

  • Platform: web

  • Browser: Firefox 57

  • OS: Linux

  • URL: riot.im/develop
@pafcu pafcu mentioned this issue Dec 12, 2017
Open
@lampholder
Copy link
Member

Should tackle at the same time as #5836.

@lampholder lampholder added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround Security 001 mistake label Help Wanted Extra attention is needed P1 and removed 001 mistake label labels Jan 11, 2018
@lukebarnard1
Copy link
Contributor

It would be fun to homogenise display names before checking for ambiguity:

  • Remove white space
  • Reduce homoglyphs to their a-z equivalents

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Feb 9, 2018 •
edited
Loading

Should tackle at the same time as #5836.

This feels like a 001 mistake comment. (That issue seems unrelated).

@pafcu
Copy link
Contributor Author

pafcu commented Feb 9, 2018 •
edited
Loading

@lampholder probably meant #5826 which is the issue about homoglyphs

@t3chguy t3chguy mentioned this issue Jul 3, 2018
Merged
@t3chguy t3chguy closed this as completed Jul 6, 2018
@turt2live turt2live mentioned this issue Dec 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Extra attention is needed P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround Security T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pafcu @lampholder @t3chguy @lukebarnard1