Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Never send to unverified devices" option does not persist page reloads #5516

Closed
turt2live opened this issue Nov 4, 2017 · 1 comment
Closed

"Never send to unverified devices" option does not persist page reloads #5516

turt2live opened this issue Nov 4, 2017 · 1 comment
Labels
Help Wanted Extra attention is needed P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

Description

The value gets saved to local storage and updates the js-sdk classes appropriately on change, however once the page reloads the value is never read back from localstorage into the js-sdk, defaulting the value to be off, despite all indications otherwise.

This was introduced in matrix-org/matrix-react-sdk#636

Steps to reproduce

  • Enable "Never send messages to unverified devices" at the account or room level
  • Refresh the page
  • Send an encrypted message to unverified devices

Log: not sent

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
@turt2live turt2live mentioned this issue Nov 5, 2017
Merged
15 tasks
@t3chguy t3chguy mentioned this issue Nov 5, 2017
Closed
@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P2 Help Wanted Extra attention is needed labels Nov 20, 2017
@turt2live
Copy link
Member Author

Fixed by granular settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Extra attention is needed P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @lampholder