Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3pid invites are not collapsed #5489

Closed
uhoreg opened this issue Nov 1, 2017 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3173
Closed

3pid invites are not collapsed #5489

uhoreg opened this issue Nov 1, 2017 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3173
Assignees
@t3chguy
Labels
Help Wanted Extra attention is needed P2 T-Defect Z-Community-PR Issue is solved by a community member's PR

Comments

@uhoreg
Copy link
Member

uhoreg commented Nov 1, 2017

image

In the screenshot above, you can see that three invites by MXID have been collapsed, but the 3PID invites are not collapsed. Also, the 3PID invites have different wording from the MXID invites. (The screenshot is from around https://matrix.to/#/!eUGMvloIjhBoAwlyRh:matrix.org/$15095479812593647HdYSs:matrix.org in #linear-supporters:matrix.org.)
@lampholder
Copy link
Member

Not collapsing is a biggy, esp. with Sync Bot's mass-inviting antics.

The 3pid invite wording might be intentionally different, inasmuch as there is a very subtle semantic difference between inviting a user and sending an invite to a user's email address, but I think I'd agree that any difference we're hoping to convey isn't worth the aesthetic downsides.

@lampholder lampholder added T-Defect Help Wanted Extra attention is needed P2 labels Nov 2, 2017
@uhoreg uhoreg mentioned this issue Nov 27, 2017
Closed
@t3chguy t3chguy self-assigned this Jul 3, 2019
@t3chguy t3chguy mentioned this issue Jul 3, 2019
Merged
@turt2live turt2live added the Z-Community-PR Issue is solved by a community member's PR label Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
Help Wanted Extra attention is needed P2 T-Defect Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MELS handle m.room.third_party_invite matrix-org/matrix-react-sdk
4 participants
@uhoreg @turt2live @lampholder @t3chguy