Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress duplicate joins #531

Closed
matrixbot opened this issue Dec 16, 2015 · 5 comments
Closed

Suppress duplicate joins #531

matrixbot opened this issue Dec 16, 2015 · 5 comments
Assignees

Comments

@matrixbot
Copy link

Created by @ matthew:matrix.org.

@ara4n
Copy link
Member

ara4n commented Dec 16, 2015

screen shot 2015-12-16 at 17 50 42

This sort of thing just makes us look crap ^

@ara4n ara4n added this to the v0 milestone Dec 17, 2015
@kegsay
Copy link
Contributor

kegsay commented Jan 13, 2016

I would argue this is not the responsibility of clients to suppress. If this were done server-side, all clients would benefit from having dupes suppressed. We don't want to suppress dupe joins over federation for reasons I forget. However, servers have no reason to expose this aberration to clients.

@erikjohnston
Copy link
Member

It looks like we do currently suppress sequential duplicate joins, which I think might be new behaviour on synapse? We would still probably get duplicate joins if someone tried to join the same room multiple times at once.

@erikjohnston erikjohnston assigned ara4n and unassigned erikjohnston Mar 18, 2016
@ara4n
Copy link
Member

ara4n commented Mar 18, 2016

so yes, this happens when people get bored of a join completing and so hit join twice - i.e. "try to join the same room multiple times at one". @erikjohnston is there any hope of suppressing this?

@ara4n ara4n assigned erikjohnston and unassigned ara4n Mar 18, 2016
@ara4n
Copy link
Member

ara4n commented Apr 13, 2016

spotted this happening in matrix-org/synapse#700. @erikjohnston please yell if i shouldn't have closed it.

@ara4n ara4n closed this as completed Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants