-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hovering over an emoji in the picker should not activate the autocomplete; surely you should have to click on it #4974
Comments
Hey @MurzNN - can you advise what browser/OS you're using and whether you've got any plugins/keyboard remappings etc. in place? I'm not seeing this, but since pressing : opens the autocomplete popup, what sounds like might be happening is that the autocomplete popup is misinterpreting something as your making a selection. What is your autocomplete delay set to in user settings? |
Minor p2 just 'cause I haven't heard of this affecting many people - if it's more common then it's more important :) |
Changed my mind - P1 until we know more about what's going on. |
Firefox 55 web browser on Ubuntu Linux with https://riot.im/develop/ website, without any keyboard plugins. autocomplete delay is 200 ms |
Now I can't repoduce this after fresh reload of webpage, seems this is effect of some previous actions in DOM. |
Yeah, reproduced: Open https://riot.im/develop/ , type "test :", select smiley from list via mouse click, after this - continue typing "test 😘 asada rooms :" and after you press last ":" - it will be instantly replaced by smiley "☺". |
@MurzNN its because your mouse is still over the autocomplete thing most likely |
Yes, mouse is still over smileys and they replaced instantly! Will be good to change bahavior to replace them by click only. |
Yes, I have the same issue. If the pointer is where the autocomplete appears, whatever emoji is under it is automatically inserted whenever I type |
So sometimes in some browsers, a mouse move event is sent when the auto complete dialog appears, even if the mouse doesn't move... Removing the |
@lukebarnard1 I disagree, TBH - not once have I wanted mousing over to replace my input, mostly because the input is the same size as the picker and so I don't really gain anything from it. I'd much prefer if |
I have this issue in Firefox 54.0.1 on Fedora 26. When the mouse is in the area where the list of emoji will appear when typing (meaning the cursor is there first), the emoji that appears under the cursor is automatically entered when I continue typing. I second the notion that |
Okay, the consensus seems to be in favour of not inserting the emoji |
I vote that emoji picker contains only emoji without text, and on hover - show sticker-sized hovered emoji with text implementation. |
Except it's not only an emoji picker but also autocomplete so if it doesn't have the short names you don't know what to type to filter further |
The worst problem is that if the mouse happens to be in region where picker list shows up, that emoji is instantly inserted (FF 55). So typing ":-)" while the mouse pointer is somewhere above the text field means some random emoji is inserted. The same is true for commands: Type /me while the mouse pointer is somewhere above the text field, and some random command is inserted. |
Also getting this in FF 55.02. I like the idea of being to hover over the emojis and see them change, but perhaps only start listening for that after you've moved the mouse after the dialog has appeared, instead of instantly replacing once the dialog comes up. |
@anoadragon453 that's the intention but #4974 (comment) |
@t3chguy Ah, missed that sorry. Seems like you guys have some idea on how to improve the situation, so I'll just wait and keep my mouse to the side for now :P |
This was quite simple in the end -- the mouse doens't move, but on some browsers, the autocomplete appearing beneath the mouse would cause the `onMouseOver`, which is not `onMouseMove`. The fix was to use `onMouseMove`. Fixes element-hq/element-web#4974
Even with "Automatically replace plain text Emoji" option disabled - sometimes text is autoreplaced with smileys instantly on typing.
For example, if I type
rooms :
text in message textarea - this text is auto replaced torooms 😁
on typing instantly after pressing:
key.Another example:
open long time :
»open long time 😗
The text was updated successfully, but these errors were encountered: