Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The day separator in the timeline also includes a time, which I find confusing #4605

Closed
lampholder opened this issue Jul 17, 2017 · 4 comments

Comments

@lampholder
Copy link
Member

lampholder commented Jul 17, 2017

This only seems to happen when the day separator is far enough back in time that it also includes a date. Separators for today, yesterday and the few days before that (identified only by their name, not the date) don't include a time.

TBH I'd prefer if it always just had the day and date in there. Today/Yesterday isn't even necessarily true if I haven't refreshed the timeline - a good solid unambiguous day and date would be very reassuring.

@turt2live
Copy link
Member

"Today" and "yesterday" are helpful to me, as it means I don't have to think about when the messages were sent. The timestamps in later breaks are strange, however.

@t3chguy
Copy link
Member

t3chguy commented Jan 14, 2018

wth DateSeparator takes a prop of showTwelveHour so this seems intentional somehow

@ara4n
Copy link
Member

ara4n commented Jan 14, 2018

The 'showTwelveHour' thing sounds like it would have been absentmindedly added by someone when adding 12h support

@t3chguy
Copy link
Member

t3chguy commented Jan 14, 2018

fair enough, DateUtils has no methods for creating date strings with no time, so adding one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants