Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You can upload any type of file as an avatar image. #3873

Open
lampholder opened this issue May 10, 2017 · 3 comments
Open

You can upload any type of file as an avatar image. #3873

lampholder opened this issue May 10, 2017 · 3 comments
Labels
A-Avatar A-User-Settings P3 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@lampholder
Copy link
Member

Related to #2581

We should validate that the file is an image file before replacing the old image.
@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P3 A-User-Settings ui/ux labels May 10, 2017
@turt2live
Copy link
Member

Related, kinda: element-hq/element-meta#2087

@turt2live turt2live mentioned this issue Jun 16, 2017
Closed
@t3chguy
Copy link
Member

t3chguy commented Aug 31, 2017

/me thinks the validation should be server side, if Synapse happily thumbnails it, all is good, else cry

@jryans jryans removed the Z-UI/UX label Mar 9, 2021
@t3chguy
Copy link
Member

t3chguy commented Dec 3, 2021

We do restrict it nowadays using accept="image/*", but this doesn't prevent the user switching their uploader to All files - we should handle errors better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Avatar A-User-Settings P3 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jryans @turt2live @lampholder @t3chguy