Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make redaction black lozenge optionally hidable #3589

Closed
ara4n opened this issue Apr 9, 2017 · 8 comments
Closed

make redaction black lozenge optionally hidable #3589

ara4n opened this issue Apr 9, 2017 · 8 comments

Comments

@ara4n
Copy link
Member

ara4n commented Apr 9, 2017

No description provided.

@lampholder
Copy link
Member

What would it look like instead? No message?

@t3chguy
Copy link
Member

t3chguy commented Apr 20, 2017

@lampholder I've seen people ask for this, its because they want the old behaviour which didn't show redactions. Someone gave an example of using a Matrix room as a todo list.

@turt2live
Copy link
Member

There's also a couple people who use https://github.com/turt2live/matrix-email-bot for mailing lists, and by nature of email, receive spam in the room or excess parts to messages. They seem to prefer the 'like it never happened' approach before the change when redacting the spam/excess bits of email.

@lampholder
Copy link
Member

It sounds like this could satisfactorily be implemented with a room-level option to choose how redacted messages are displayed (or otherwise). What options would we want to support? Is it as simple as visible/invisible?

@turt2live
Copy link
Member

Quite possibly. A similar option to URL previews in rooms would probably be okay. Another suggestion appears to be here: #3657

image
(for reference)

@t3chguy
Copy link
Member

t3chguy commented Jun 2, 2017

going to implement this as an account level thing for now (SyncedSetting) and it will be dragged onto Granular Settings once they are implemented. At least this way it can restore the old behaviour if someone so wishes.

@turt2live
Copy link
Member

This seems to be resolved?

@t3chguy
Copy link
Member

t3chguy commented Jun 29, 2017

in a broken manner, but yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants