Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clientside search for e2e rooms #3413

Closed
ara4n opened this issue Mar 11, 2017 · 4 comments
Closed

Support clientside search for e2e rooms #3413

ara4n opened this issue Mar 11, 2017 · 4 comments

Comments

@ara4n
Copy link
Member

ara4n commented Mar 11, 2017

We should support searching the clientside history cache for e2e rooms. This means that history would need to be stored (or indexed) unencrypted. And ideally we should save as much history as possible.

@ylecollen
Copy link

We need to know the algorithm used by the server : it seems that some words are replaced.

@ara4n
Copy link
Member Author

ara4n commented Mar 13, 2017

the algorithm isn't defined and depends on the server. for instance, both sqlite & postgres provide different full-text-search implementations, so depending on which one your synapse is using, you'll get different results.

in other words: we should use the best full-text search engine available for a given platform (without spending too much time on it). On Android I suspect the simplest solution is sqlite as per https://developer.android.com/training/search/search.html, which will end up behaving the same as on Synapse-with-Sqlite. The code for that is around https://github.com/matrix-org/synapse/blob/develop/synapse/storage/search.py#L298

Failing that, https://www.google.co.uk/search?q=android+full-text+search+library+stemming gives a bunch of alternative ideas.

@uhoreg
Copy link
Member

uhoreg commented Mar 15, 2017

looks like a dup of #2548

@ara4n
Copy link
Member Author

ara4n commented Mar 15, 2017

so it is - thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants