Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CmdShiftH keyboard shortcut hijacks the Safari shortcut for Home #28576

Open
gy-mate opened this issue Nov 27, 2024 · 4 comments · Fixed by #28577 · May be fixed by #29374
Open

CmdShiftH keyboard shortcut hijacks the Safari shortcut for Home #28576

gy-mate opened this issue Nov 27, 2024 · 4 comments · Fixed by #28577 · May be fixed by #29374
Labels
A-Shortcuts Keyboard shortcuts O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@gy-mate
Copy link
Contributor

gy-mate commented Nov 27, 2024

Steps to reproduce

  1. Open a room
  2. Press CmdShiftH

Outcome

What did you expect?

Safari goes to the Home page set in its Settings.

What happened instead?

Hidden events become visible.

I think that Element shouldn't hijack a Safari keyboard shortcut like this one because it serves a different purpose.

Similar issue: #14381
Older counter-issue: #19850
Same issue in another repo: openstreetmap/iD#10479

Operating system

macOS 15.3.1

Browser information

Safari 18.3

URL for webapp

https://develop.element.io/

Application version

Element 0997e0a747f7-js-d81929de4c95 (1.11.93+)

Homeserver

https://riot.grin.hu/

Will you send logs?

No

@dosubot dosubot bot added A-Shortcuts Keyboard shortcuts O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Nov 27, 2024
@gy-mate
Copy link
Contributor Author

gy-mate commented Feb 20, 2025

@florianduros I've updated the issue description—the problem unfortunately still persists. Do you have an idea why the PR didn't fix it?

@t3chguy
Copy link
Member

t3chguy commented Feb 20, 2025

@gy-mate the PR hasn't been in a release yet. Have you tried develop.element.io

@gy-mate
Copy link
Contributor Author

gy-mate commented Feb 27, 2025

My bad—thanks!

Since then, the PR has been released in version 1.11.93. But unfortunately the issue still persists—now a different KeyBindingAction hijacks the Safari shortcut for Home. I've updated the issue description.

@t3chguy @florianduros Could you please reopen this issue? I'd like to submit another PR linked to it.

@florianduros florianduros reopened this Feb 27, 2025
@gy-mate gy-mate linked a pull request Feb 27, 2025 that will close this issue
4 tasks
@gy-mate
Copy link
Contributor Author

gy-mate commented Feb 27, 2025

@florianduros Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Shortcuts Keyboard shortcuts O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
3 participants