Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse invites into joins and parts more efficiently #2842

Closed
ara4n opened this issue Dec 27, 2016 · 2 comments
Closed

Collapse invites into joins and parts more efficiently #2842

ara4n opened this issue Dec 27, 2016 · 2 comments

Comments

@ara4n
Copy link
Member

ara4n commented Dec 27, 2016

See #74. @lukebarnard1 implemented collapsing joins/parts, but it could take up less room:

  • The collapsed view should be entirely replaced when expanded, rather than the expansion being added to the collapsed summary
  • Invites should be included as well as joins/parts in the collapsing, otherwise every time an IRC user joins, they are first invited by the bridge and so break the collapsing.
@lukebarnard1 lukebarnard1 self-assigned this Dec 28, 2016
@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jan 11, 2017

The collapsed view should be entirely replaced when expanded, rather than the expansion being added to the collapsed summary

@ara4n: does this mean it should not be toggle-able?

Invites should be included as well as joins/parts in the collapsing, otherwise every time an IRC user joins, they are first invited by the bridge and so break the collapsing.

Should the invites be included in the summary? E.g. "12256 people were invited"

Also, I think we could fix #2594 at the same time by handling all kinds of member events. How do we feel about "123 people were banned/kicked/invited" being included?

Discussion about ordering/causality problem: #2856 (comment)

@ara4n
Copy link
Member Author

ara4n commented Jan 11, 2017

We should still be able to expand/collapse; let's just put the toggle at the end of the topmost message (whether it is expanded or collapsed).

Yes, let's include invites too. So the categories end up being joined/left/kicked/banned/invited, ordered chronologically as per #2856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants