Mark as read not sending the correct command to mark as read

[niebloomj]

Steps to reproduce

1. Where are you starting? What can you see?

I see a chat that is marked as unread (without a number next to it)

2. What do you click?
   I click this button
   

3. I see that the chat is NOT marked as read

4. I type /devtools to see a developer popup

5. I see that the state is marked as unread here
   

6. I edit the message and update the JSON to be an empty dict.

7. I click send

8. I see that the chat is now marked as read properly. I assume this unread state is being considered for the indicator but not one of the states that are updated by clicking mark as read.

Outcome

What did you expect?

I expected the chat to be marked as read

What happened instead?

It remained unread.

Operating system

macOS

Application version

Version 2024071801 (2024071801)

How did you install the app?

Github Download

Homeserver

Dendrite 0.13.7

Will you send logs?

Yes

[dbkr]

In step 3, did you mean 'read' or 'unread'?

This could be a bug with stable / unstable prefix support for mark as unread though, since the devtools show it's been set with the stable prefix (although we don't know with what client).

[niebloomj]

Step 3 wording is correct. After I click the button, the state does not change and the chat is not being marked as read.

[niebloomj]

I noticed the change from frequent to occasional. If I understand that label correctly, this is in fact happening incredibly frequently. Anytime that state is present for a specific chat, mark as read does not work.

[t3chguy]

@niebloomj please read the label description. Given this is only a single user's report of such, it can't be Frequent.

[niebloomj]

Gotcha thanks! I didn't see that on mobile.

[niebloomj]

Issue still persists on latest element nightly and denrite main branch

[t3chguy]

Fixed by #28478 prior to which we only sent the unstable but would prefer the stable which could cause such a "stuck" unread