Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant Statement in Deactivate Account Popup | Possibly a bug? #27488

Closed
linuxmunchies opened this issue May 20, 2024 · 3 comments · Fixed by matrix-org/matrix-react-sdk#12668
Assignees
Labels
A-User-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@linuxmunchies
Copy link

Steps to reproduce

Hello all! I noticed something strange in the Deactivate Account page in the Desktop Element app. I went to Settings, then to General, then Deactivate Account to get to the correct area where the 'bug' seems to occur. At the bottom, there seems to be two redundant statements basically telling you to enter your password. I feel as if this might have been an oversight or potentially a bug, as there should only be one statement instructing the user to do this. The statements I'm talking about are as follows:

  1. "To continue, please enter your account password:"
  2. "Confirm your identity by entering your account password below."
    I have added the screenshot of the aforementioned popup panel I am talking about below, where you can see the two lines towards the bottom.
    image

I would imagine that having just the first statement or a combination of the two into one would be the solution here. Don't get me wrong, the intent of both messages are clear. It's just a bit redundant and unnecessary to have it basically repeated twice here. What are your thoughts?

Outcome

What did you expect?

For there to only be one statement telling the user to enter their password.

What happened instead?

I saw two! 😲

Operating system

Windows

Application version

Element version: 1.11.66

How did you install the app?

https://element.io

Homeserver

matrix.org

Will you send logs?

No

@dosubot dosubot bot added A-User-Settings S-Minor Impairs non-critical functionality or suitable workarounds exist labels May 20, 2024
@MidhunSureshR MidhunSureshR added the O-Occasional Affects or can be seen by some users regularly or most users rarely label May 23, 2024
@gaelledel
Copy link

To remove the string: "Confirm your identity by entering your account password below."

@t3chguy
Copy link
Member

t3chguy commented Jun 20, 2024

@gaelledel that is part of the generic UIA flow, it'd be easier to remove the other line:
To continue, please enter your account password: which is specific to this screen

@gaelledel
Copy link

Ok @t3chguy, @MidhunSureshR when you get to this, please remove the first sentence instead: "To continue, please enter your account password:"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-User-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants