Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on the "Threads" text to show the Threads Activity Center causes it to be dismissed immediately #27335

Closed
langleyd opened this issue Apr 15, 2024 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12438
Assignees
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@langleyd
Copy link
Member

Steps to reproduce

  1. Go to Notifications Settings and enabled all activity in the Threads Activity Center
  2. Expand Spaces list so that you can see the TAC "Threads" text fully
  3. Click on the upper half of the "Threads" text

Outcome

What did you expect?

The TAC opens

What happened instead?

The TAC opens on the down click and is dismissed up the up click and the last row in the TAC is selected.

Operating system

macOS

Browser information

Version 123.0.6312.122 (Official Build) (x86_64)

URL for webapp

develop

Application version

Element version: 8ce46d3-react-6392759bec51-js-843853353204 Crypto version: Rust SDK 0.7.0 (61b175b), Vodozemac 0.5.1

Homeserver

matrix.org

Will you send logs?

Yes

@dbkr dbkr changed the title When clock on the "Threads" text to show the Threads Activity Center the is dismissed immediately. Clicking on the "Threads" text to show the Threads Activity Center causes it to be dismissed immediately Apr 15, 2024
@dbkr
Copy link
Member

dbkr commented Apr 15, 2024

So, this is radix doing this: https://github.com/radix-ui/primitives/blob/main/packages/react/menu/src/Menu.tsx#L647 combined with the fact that the popup appear as if it came from just the icon, rather than the 'Threads' label, and therefore appears over the 'Threads' label so the newly created popup catches the mouseup and generates a click, immediately selecting whatever was under the cursor.

The only options I can think of for fixing this are:

  1. Convince radix that this is a bug and requires tracking the mousedown events so we ignore mouseups if the mousedown didn't occur within the menu
  2. Horrendous hack like ignoring item selections for the first 10ms after the menu opens 🤮
  3. Move the menu to the right of the label if the spaces panel is expanded.

Opinions? Should the TAC be to the right of the label anyway?

@dbkr dbkr self-assigned this Apr 16, 2024
@dbkr dbkr added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Threads labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants