Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redacting a poll vote makes the poll widget crash #27223

Closed
jaller94 opened this issue Mar 21, 2024 · 2 comments · Fixed by #28498
Closed

Redacting a poll vote makes the poll widget crash #27223

jaller94 opened this issue Mar 21, 2024 · 2 comments · Fixed by #28498
Assignees
@t3chguy
Labels
T-Defect

Comments

@jaller94
Copy link
Contributor

jaller94 commented Mar 21, 2024 •
edited
Loading

Steps to reproduce

  1. Have someone create a poll
  2. Vote
  3. Enable hidden events in the dev tools
  4. Redact your org.matrix.msc3381.poll.response event

Outcome

What did you expect?

The poll widget resets to what it looked like before I voted.

What happened instead?

The poll widget got replaced with Can't load this message (org.matrix.msc3381.poll.start) Submit debug logs

Operating system

Manjaro Linux (based on the Arch repo)

Browser information

Mozilla Firefox 124.0

URL for webapp

element.nordeck.io

Application version

Element version: 1.11.60 Crypto version: Olm 3.2.15

Homeserver

Some Synapse

Will you send logs?

Yes
@t3chguy
Copy link
Member

t3chguy commented Mar 21, 2024

Revoke your org.matrix.msc3381.poll.response event

What does this mean? The verb Revoke is only used in the context of permissions and 3pids in the app.

@t3chguy t3chguy added the X-Needs-Info This issue is blocked awaiting information from the reporter label Mar 21, 2024
@HarHarLinks
Copy link
Contributor

from context: "redact"

@jaller94 jaller94 changed the title Revoking a poll vote makes the poll widget crash Redacting a poll vote makes the poll widget crash Mar 22, 2024
@t3chguy t3chguy removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Nov 20, 2024
@t3chguy t3chguy self-assigned this Nov 20, 2024
@t3chguy t3chguy mentioned this issue Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filter out redacted poll votes to avoid crashing the Poll widget element-hq/element-web
3 participants
@t3chguy @HarHarLinks @jaller94