Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element-R: add labs button to migrate to rust crypto #26772

Closed
Tracked by #26678
richvdh opened this issue Dec 15, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12114
Closed
Tracked by #26678

Element-R: add labs button to migrate to rust crypto #26772

richvdh opened this issue Dec 15, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12114
Assignees
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Enhancement Z-Labs

Comments

@richvdh
Copy link
Member

richvdh commented Dec 15, 2023

The part of migration to Rust Crypto that actually adds a labs button. Not a strict dependency, but we probably don't want to land this until matrix-org/matrix-js-sdk#3964 is done, since otherwise it will eat peoples' data.

We make the existing "Rust cryptography implementation" labs button turn-on-able. (Currently, it is always disabled; change it to only be disabled when the feature is on; see RustCryptoSdkController.) We also make it reload the app when it is switched on; see ReloadOnChangeController for examples of how to do this. Some changes needed to the wording on the button.

This means that, once we restart, MatrixClientPeg.initClientCrypto will find useRustCrypto is true, causing it to call MatrixClient.initRustCrypto instead of MatrixClient.initCrypto. (This will be much the same codepath as when we drop legacy crypto support, which is good.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Enhancement Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@richvdh @MidhunSureshR and others