Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: "Reset cross signing" button prompts for security phrase 3 times #26321

Closed
richvdh opened this issue Oct 6, 2023 · 5 comments · Fixed by matrix-org/matrix-react-sdk#12059
Closed

Element-R: "Reset cross signing" button prompts for security phrase 3 times #26321

richvdh opened this issue Oct 6, 2023 · 5 comments · Fixed by matrix-org/matrix-react-sdk#12059
Assignees
@richvdh
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Oct 6, 2023

  • In settings, under "Cross Signing", click "Reset"
  • Confirm that you really want to
  • Enter security phrase/key (not sure what you'd do if you'd forgotten?)
  • and again
  • and again
@richvdh richvdh added T-Defect A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Oct 6, 2023
@richvdh
Copy link
Member Author

richvdh commented Oct 6, 2023 •
edited
Loading

Possibly related to #26322

@richvdh
Copy link
Member Author

richvdh commented Oct 6, 2023 •
edited
Loading

Enter security phrase/key (not sure what you'd do if you'd forgotten?)

Answer: somewhat unintuitively IMHO, you'd have to click "Reset" under "Secure Backup".

(Related: https://github.com/vector-im/crypto-internal/issues/144#issuecomment-1715563519)

@BillCarsonFr BillCarsonFr added the Z-Element-R-Blocker A blocker for enabling Element R by default label Nov 8, 2023
@richvdh
Copy link
Member Author

richvdh commented Nov 8, 2023

Related: #26468

@BillCarsonFr BillCarsonFr removed the Z-Element-R-Blocker A blocker for enabling Element R by default label Nov 23, 2023
@github-actions github-actions bot removed the Z-Labs label Nov 23, 2023
@BillCarsonFr
Copy link
Member

Not a blocker. Notice that this flow will be deprecated by OIDC

@richvdh richvdh self-assigned this Dec 13, 2023
@richvdh
Copy link
Member Author

richvdh commented Dec 13, 2023

This works on legacy because there is a cache of the secret storage keys in legacy crypto (https://github.com/matrix-org/matrix-js-sdk/blob/v30.2.0/src/crypto/EncryptionSetup.ts#L326), in addition to the application-side cache in SecurityManager.getSecretStorageKey.

I think we just need to call accessSecretStorage in CrossSigningPanel.

@richvdh richvdh mentioned this issue Dec 15, 2023
Merged
@estellecomment estellecomment mentioned this issue Feb 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richvdh richvdh

Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Defect
Projects
None yet
Milestone
No milestone
3 participants
@germain-gg @richvdh @BillCarsonFr