Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FacePile component visual regression #26112

Closed
t3chguy opened this issue Sep 4, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11527
Closed

FacePile component visual regression #26112

t3chguy opened this issue Sep 4, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11527
Assignees
@t3chguy
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression X-Release-Blocker

Comments

@t3chguy
Copy link
Member

t3chguy commented Sep 4, 2023

Steps to reproduce

  1. Explore a space

Regressed by matrix-org/matrix-react-sdk#11356

Outcome

What did you expect?

No overlapping UI elements

What happened instead?

image

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@t3chguy
Copy link
Member Author

t3chguy commented Sep 4, 2023

The left side of the button is unclickable which will wreak havoc with some voice control accessibility technologies which manage the user's cursor.

@Johennes
Copy link
Contributor

Johennes commented Sep 4, 2023

This appears to occur in all spaces you have permissions to send invites, which affects a lot of public spaces.

@t3chguy t3chguy self-assigned this Sep 4, 2023
This was referenced Sep 4, 2023
Closed
Merged
@kittykat kittykat added S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regression around FacePile with overflow matrix-org/matrix-react-sdk
3 participants
@kittykat @Johennes @t3chguy