Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secure_backup_required in .well-known/matrix/client has no effect #26077

Closed
rltas opened this issue Aug 30, 2023 · 7 comments
Closed

secure_backup_required in .well-known/matrix/client has no effect #26077

rltas opened this issue Aug 30, 2023 · 7 comments
Labels
A-Config A-E2EE-Key-Backup O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Investigation

Comments

@rltas
Copy link

rltas commented Aug 30, 2023

Steps to reproduce

My https://mydomain.net/.well-known/matrix/client:

{
    "im.vector.riot.e2ee": {
        "default": false
    },
    "io.element.e2ee": {
        "default": false,
        "secure_backup_required": true,
        "secure_backup_setup_methods": ["passphrase"]
    },
    "m.homeserver": {
        "base_url": "https://matrix.mydomain.net"
    },
    "org.matrix.msc3575.proxy": {
        "url": "https://matrix.mydomain.net/sliding-sync"
    }
}

I know it's generally working because the default encryption setting is honored.
Update: my colleague just said this works in Element on iOS, but not in Element Web.

Outcome

What did you expect?

That I can use Element only after setting up secure backup as per the docs.

What happened instead?

No visible change.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

Element version 1.11.38, Olm version 3.2.14

Homeserver

Synapse version 1.89.0

Will you send logs?

No

@rltas rltas added the T-Defect label Aug 30, 2023
@dbkr dbkr added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-E2EE-Key-Backup A-Config X-Needs-Investigation O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 7, 2023
@t3chguy
Copy link
Member

t3chguy commented Sep 26, 2023

Will you send logs?
No

Please send logs

@t3chguy t3chguy added the X-Needs-Info This issue is blocked awaiting information from the reporter label Sep 26, 2023
@rltas
Copy link
Author

rltas commented Sep 26, 2023

Will you send logs?
No

Please send logs

Of what exactly?

@t3chguy
Copy link
Member

t3chguy commented Sep 26, 2023

Of the app
image

@rltas
Copy link
Author

rltas commented Sep 26, 2023

Dunno why I thought this was meant for something different - just sent it.

@t3chguy
Copy link
Member

t3chguy commented Sep 26, 2023

secure_backup_required is false in your deployment, also be careful you serve the file in 2 places.

bXX-XXXt.XX-XX.net & matrix.bXX-XXXt.XX-XX.net - the former is the only valid as per https://spec.matrix.org/v1.8/client-server-api/#well-known-uri

I suggest retrying once you ensure the former URL has secure_backup_required=true

@rltas
Copy link
Author

rltas commented Sep 26, 2023

Yeah I noticed that too, that seems to be some quirk with the ansible playbook but it's the same file being served under both urls. I changed the setting back after submitting the report, that's why it was false - I can keep it true and give you a test user if that helps.

What I just figured out:

  • upon first logging in with a fresh user, no backup is enforced
  • when logging in and skipping verification, no backup is enforced
  • when logging in and resetting keys, backup is enforced
  • when hitting F5 at that point, no backup is enforced

Is that behaviour intentional? Eventually it's how it's meant to work, but if so it's unintuitive as I can manually configure a backup anytime, starting with a fresh user, and that seemingly arbitrary flow makes it harder to on-ramp users with a step-by-step guide.

/e: I assume that behaviour is not intentional as I can as well just cancel the backup setup and move on, which isn't in line with what the setting is meant to achieve according the docs ("Setup that backup now or you're going nowhere").

@t3chguy t3chguy added Team: Crypto and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Sep 26, 2023
@richvdh
Copy link
Member

richvdh commented Jun 26, 2024

seems like this was a config error

@richvdh richvdh closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Config A-E2EE-Key-Backup O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Investigation
Projects
None yet
Development

No branches or pull requests

4 participants