Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hovering over a room avatar shows the room ID in a tooltip #26055

Closed
robintown opened this issue Aug 25, 2023 · 3 comments · Fixed by element-hq/compound-web#66 or matrix-org/matrix-react-sdk#11526
Closed

Hovering over a room avatar shows the room ID in a tooltip #26055

robintown opened this issue Aug 25, 2023 · 3 comments · Fixed by element-hq/compound-web#66 or matrix-org/matrix-react-sdk#11526
Assignees
@t3chguy
Labels
A-Avatar O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. Hover over the avatar of a room or space that actually has an image set

Outcome

What did you expect?

No tooltip

What happened instead?

The room ID appears in a tooltip, which I find surprising - room IDs aren't useful to most people apart from developers, and this seems like an odd place to expose it

Screenshot from 2023-08-25 08-30-29

Operating system

NixOS unstable

Browser information

Firefox 115.0.2

URL for webapp

develop.element.io

Application version

Element version: fcd8052-react-23897dff4f79-js-5788d9744b76 Olm version: 3.2.14

Homeserver

Not relevant

Will you send logs?

No
@robintown robintown added T-Defect X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A-Avatar O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 25, 2023
@t3chguy
Copy link
Member

t3chguy commented Aug 25, 2023

Room IDs leaking out into non-developer/advanced UI is definitely unexpected

@Johennes
Copy link
Contributor

Johennes commented Aug 28, 2023 •
edited
Loading

This appears to be happening because Compound's Avatar component fills the title attribute from the id property rather than the title property.

@Johennes
Copy link
Contributor

@germain-gg I'm not sure if that was intentional or not? It feels like it could be somewhat helpful for DMs when the ID is the user ID but less so for rooms.

@germain-gg germain-gg self-assigned this Aug 29, 2023
This was referenced Aug 30, 2023
Merged
Merged
@t3chguy t3chguy reopened this Sep 4, 2023
This was referenced Sep 4, 2023
Merged
Merged
@t3chguy t3chguy assigned t3chguy and unassigned germain-gg Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Avatar O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
4 participants
@germain-gg @Johennes @t3chguy @robintown