Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu on room list header on LeftPanel should be closed if Show all rooms is disabled #25556

Closed
luixxiul opened this issue Jun 10, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11647
Closed

Context menu on room list header on LeftPanel should be closed if Show all rooms is disabled #25556

luixxiul opened this issue Jun 10, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11647
Labels
Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@luixxiul
Copy link

Steps to reproduce

  1. Create a room
  2. Create a Space
  3. Add the room to the Space
  4. Open the room on Home
  5. Enable Show all rooms with context menu opened on room list header on LeftPanel if not
  6. Disable Show all rooms with the context menu on LeftPanel

Outcome

What did you expect?

The context menu should be closed

What happened instead?

It remains opened, and the content is replaced for the Space

0.mp4

Operating system

Debian

Browser information

Firefox

URL for webapp

develop.element.io

Application version

No response

Homeserver

No response

Will you send logs?

No
@kittykat kittykat added S-Minor Impairs non-critical functionality or suitable workarounds exist Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jun 15, 2023
@manancodes manancodes mentioned this issue Sep 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: onFinished added which closes the menu manancodes/matrix-react-sdk
2 participants
@kittykat @luixxiul