Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Room Link should work on DMs #23239

Open
ara4n opened this issue Sep 7, 2022 · 4 comments
Open

Copy Room Link should work on DMs #23239

ara4n opened this issue Sep 7, 2022 · 4 comments
Labels
A-DMs O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Product More input needed from the Product team

Comments

@ara4n
Copy link
Member

ara4n commented Sep 7, 2022

Steps to reproduce

Just because you've tagged a room as DM doesn't mea you don't want to be able to copy a link to it to refer to it in a different room.

Outcome

What did you expect?

Copy Link works on any room in the room list

What happened instead?

It only works on Rooms, not DMs

Operating system

macOS

Application version

nightly

How did you install the app?

nightly

Homeserver

matrix.org

Will you send logs?

No
@ara4n ara4n added the T-Defect label Sep 7, 2022
@t3chguy t3chguy added the X-Needs-Product More input needed from the Product team label Sep 8, 2022
@t3chguy
Copy link
Member

t3chguy commented Sep 8, 2022

This was chosen by product to not scare users into thinking that leaking such a link would let anyone into their private DMs

@t3chguy
Copy link
Member

t3chguy commented Sep 8, 2022

Related #19344

@ara4n
Copy link
Member Author

ara4n commented Sep 8, 2022

i think the product thinking is incorrect here; you can have a link to something without having permission to follow that link.

@duxovni duxovni added S-Minor Impairs non-critical functionality or suitable workarounds exist A-DMs O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Sep 9, 2022
@Johennes
Copy link
Contributor

Johennes commented Sep 8, 2023

This strikes me as a fairly small use case because only you and the other person would be able to actually use that link. I had the counter example happen to me this week where I meant to share somebody's MXID and absentmindedly copied the room ID via the "Share room" option in the DM's right panel.

Given that we've consciously chosen to make it like it is today, I'm going to relabel this as enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-DMs O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Product More input needed from the Product team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Johennes @ara4n @t3chguy @duxovni