Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give methods in Platform public/private/protected declarations #22235

Closed
SimonBrandner opened this issue May 17, 2022 · 0 comments · Fixed by element-hq/element-desktop#375
Closed

Give methods in Platform public/private/protected declarations #22235

SimonBrandner opened this issue May 17, 2022 · 0 comments · Fixed by element-hq/element-desktop#375
Assignees
@t3chguy
Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely T-Task Tasks for the team like planning

Comments

@SimonBrandner
Copy link
Contributor

SimonBrandner commented May 17, 2022 •
edited
Loading

@SimonBrandner SimonBrandner mentioned this issue May 17, 2022
Merged
@SimonBrandner SimonBrandner added T-Task Tasks for the team like planning A-Testing Testing, code coverage, etc. A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely labels May 17, 2022
@t3chguy t3chguy added the good first issue Good for newcomers label May 17, 2022
This was referenced Jun 5, 2022
Merged
Merged
@t3chguy t3chguy self-assigned this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Abstract electron settings properly to avoid boilerplate-hell element-hq/element-desktop
2 participants
@t3chguy @SimonBrandner