Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old filter-based invite UI from MemberList #2200

Closed
ara4n opened this issue Sep 14, 2016 · 4 comments · Fixed by #2211
Closed

Remove old filter-based invite UI from MemberList #2200

ara4n opened this issue Sep 14, 2016 · 4 comments · Fixed by #2211
Assignees
Labels

Comments

@ara4n
Copy link
Member

ara4n commented Sep 14, 2016

If necessary, we can just comment out the bit which renders the invite-search results? i.e. the top half of the filtered MemberList

@wmwragg
Copy link
Contributor

wmwragg commented Sep 14, 2016

@ara4n Cool. So we'd just see a list of users in the room, and no search/invite, as that should be pretty simple

@ara4n
Copy link
Member Author

ara4n commented Sep 14, 2016

no - we need to keep the filtered search results; i'm just suggesting we hide the div which shows the invite results (as an ugly workaround) if a bigger refactor is going to be hard.

@wmwragg
Copy link
Contributor

wmwragg commented Sep 14, 2016

Right, When I looked at that yesterday, it was a little more complicated than that, as you then see some member tile as the first position rather than the Invite email. But I was in a rush yesterday, so I'll take another look

@wmwragg
Copy link
Contributor

wmwragg commented Sep 14, 2016

Implement the RHS Panel from https://zpl.io/Z13pkVG well just the filter section? If so shouldn't be too difficult, probably a couple of hours at max.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants