Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

per-room RightPanel should not remember Notifications card, as it's global #21529

Closed
ara4n opened this issue Mar 23, 2022 · 9 comments
Closed

per-room RightPanel should not remember Notifications card, as it's global #21529

ara4n opened this issue Mar 23, 2022 · 9 comments
Labels
A-Notif-Panel A-Notifications A-Right-Panel good first issue Good for newcomers Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-GetYourUpdates

Comments

@ara4n
Copy link
Member

ara4n commented Mar 23, 2022

Steps to reproduce

  1. Be in a room
  2. Display the notifications panel to check for missed notifs in general
  3. Move to a different room
  4. Go back again
  5. Feel confused by the rightpanel showing notifications, given notifications are global, not per-room.

Outcome

What did you expect?

Don't restore the notificationpanel when you view a room (similar to #21487, but for unexpectedly getting dumped in the notifpanel)

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No
@ara4n ara4n added the T-Defect label Mar 23, 2022
@germain-gg germain-gg added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Right-Panel O-Occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers labels Mar 23, 2022
@turt2live
Copy link
Member

Related: #5383

For contributors: scoping this issue to exactly what's described in the title is best, as otherwise the scope gets complex. Talk to us in #element-dev:matrix.org for questions :)

@alsoarpit
Copy link

@SimonBrandner @turt2live Please can you elaborate me how to reproduce this bug.

@SimonBrandner
Copy link
Contributor

Don't restore the notificationpanel when you view

In room A open the notif panel, switch to room B, switch back to room A, see the notif panel open again (which it shouldn't be)

@yaya-usman
Copy link
Contributor

@SimonBrandner interesting, i should probably give it a try, you can assign me the issue if @arpit-maurya doesn't work on it or you can assign us both if it's possible

@ShivraniAJ
Copy link
Contributor

Hi, I am Shivrani, I am selected as outreachy initial applicant, Please can you assign this issue to me?

@SimonBrandner
Copy link
Contributor

Hi, I am Shivrani, I am selected as outreachy initial applicant, Please can you assign this issue to me?

I've assigned you to the issue. If you need any help/have any questions be sure to visit #element-dev:matrix.org!

@ShivraniAJ
Copy link
Contributor

ShivraniAJ commented Mar 30, 2022 •
edited
Loading

Hi, I am Shivrani; I am selected as outreachy initial applicant, Please can you assign this issue to me?

I've assigned you to the issue. If you need any help/have any questions be sure to visit #element-dev:matrix.org!

Yaa, sure I will communicate there for doubts.

@ShivraniAJ ShivraniAJ mentioned this issue Apr 9, 2022
Closed
@kittykat kittykat added the Help Wanted Extra attention is needed label May 4, 2022
@andybalaam
Copy link
Member

matrix-org/matrix-react-sdk#8273 may be still under development. I have asked there.

@t3chguy t3chguy assigned t3chguy and unassigned ShivraniAJ and t3chguy May 25, 2022
@t3chguy t3chguy mentioned this issue Sep 6, 2022
Closed
@ara4n ara4n mentioned this issue Sep 6, 2022
Closed
@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2023

Closing in favour of #5383

@t3chguy t3chguy closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Notif-Panel A-Notifications A-Right-Panel good first issue Good for newcomers Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-GetYourUpdates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix per-room RightPanel should not remember Notifications card ShivraniAJ/matrix-react-sdk