Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redacted invite and join events disappear from the timeline #20959

Closed
heftig opened this issue Feb 7, 2022 · 3 comments · Fixed by matrix-org/matrix-react-sdk#7768
Closed

Redacted invite and join events disappear from the timeline #20959

heftig opened this issue Feb 7, 2022 · 3 comments · Fixed by matrix-org/matrix-react-sdk#7768
Assignees
@t3chguy
Labels
A-Invite A-Redaction A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@heftig
Copy link

heftig commented Feb 7, 2022

Steps to reproduce

  1. Invite another user to a room
  2. Redact the invitation from the timeline

Outcome

What did you expect?

The invitation is withdrawn.

What happened instead?

The invitation disappeared completely from the timeline but the user stayed invited. They merely lost their nick and avatar.

Operating system

Arch Linux

Browser information

Firefox 98.0a1

URL for webapp

app.element.io

Application version

Element version: 1.10.1 Olm version: 3.2.8

Homeserver

archlinux.org, Synapse 1.51.0

Will you send logs?

No
@heftig heftig added the T-Defect label Feb 7, 2022
@SimonBrandner SimonBrandner added A-Invite A-Redaction O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Timeline labels Feb 7, 2022
@heftig
Copy link
Author

heftig commented Feb 7, 2022

It seems you actually need kick permissions to withdraw invitations, but the current effect of hiding the invitation from the timeline is still inappropriate. The event should stay visible, even if nick and avatar are gone.

@heftig
Copy link
Author

heftig commented Feb 8, 2022

The same happens when join events get redacted, which I just saw happening with Mjolnir. They just disappear from the timeline.

I don't think this used to happen, so it's a regression. Perhaps from when the bubble layout was implemented?

@heftig heftig changed the title Redacting an invite event has unexpected results Redacted invite and join events disappear from the timeline Feb 8, 2022
@t3chguy
Copy link
Member

t3chguy commented Feb 8, 2022

Perhaps from when the bubble layout was implemented?

The bubble layout didn't change which events got rendered, only added layout specific attributes to them

@t3chguy t3chguy self-assigned this Feb 9, 2022
@t3chguy t3chguy mentioned this issue Feb 9, 2022
Merged
@t3chguy t3chguy mentioned this issue Feb 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Invite A-Redaction A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix state events being wrongly hidden when redacted matrix-org/matrix-react-sdk
3 participants
@heftig @t3chguy @SimonBrandner