Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL previews for SVGs fail uglily #2008

Open
richvdh opened this issue Aug 25, 2016 · 3 comments
Open

URL previews for SVGs fail uglily #2008

richvdh opened this issue Aug 25, 2016 · 3 comments
Labels
A-URL-Previews P2 S-Tolerable Low/no impact on users T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Aug 25, 2016

we don't support SVG previewing due to the billion-lols, so we shoudn't show a broken preview link when someone pastes a link to an svg
@richvdh
Copy link
Member Author

richvdh commented Aug 25, 2016

This might be the same as #1341 actually, but this is about links to externally-hosted SVGs (eg https://upload.wikimedia.org/wikipedia/commons/8/88/Inuktitut_dialect_map.svg) as opposed to those hosted in our media repo)

@ara4n ara4n added T-Defect P2 S-Tolerable Low/no impact on users labels Aug 26, 2016
@ara4n ara4n changed the title SVG previews fail uglily URL previews for SVGs fail uglily Apr 29, 2018
@aaronraimist aaronraimist mentioned this issue Sep 17, 2019
Open
@ara4n
Copy link
Member

ara4n commented Sep 17, 2019

We could solve this by blatting the SVGs through https://github.com/cure53/DOMPurify to sanitise them.

@ara4n ara4n mentioned this issue Sep 17, 2019
Open
@estellecomment estellecomment mentioned this issue Mar 26, 2024
Open
@revolunet
Copy link

Hello! I'd be pleased to help land SVG support in element client. is it still a feature you want ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-URL-Previews P2 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@revolunet @ara4n @richvdh @aaronraimist