Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion UX #1973

Closed
jansol opened this issue Aug 16, 2016 · 2 comments
Closed

Autocompletion UX #1973

jansol opened this issue Aug 16, 2016 · 2 comments
Assignees

Comments

@jansol
Copy link
Contributor

jansol commented Aug 16, 2016

The current tab completion is still a mess UX-wise and some coherent design is needed before releasing it to the mainstream public.

IMHO a sensible behaviour would be similar to e.g. zsh's or slack's completion. My suggestion:

  1. The completion popup may show automatically, but has no entry selected and does not insert a completion until the user presses tab.
  2. Pressing tab inserts the first completion but does not dismiss the popup. (or maybe dismiss, this needs some thought)
  3. Subsequent presses of tab cycle through possible completions.
    -- Arrow keys may navigate through completions as well.
  4. Pressing enter inserts the currently selected completion and closes the popup.
  5. Furthermore, pressing esc at any point dismisses the popup without further modifying the input box.
@aviraldg aviraldg self-assigned this Aug 16, 2016
@superdump
Copy link
Contributor

Agree with all of the above points.

For point 2, I agree with tab should not dismiss the popup. The reasoning is that the popup list gives context for how many times one may need to press tab for point 3.

@jansol
Copy link
Contributor Author

jansol commented Aug 16, 2016

Closing as a duplicate of #1761

@jansol jansol closed this as completed Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants