Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show old versions of a room in a space even if that space has been updated with the new room #19209

Open
babolivier opened this issue Sep 28, 2021 · 3 comments
Labels
A-Room-Upgrades A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement

Comments

@babolivier
Copy link
Contributor

Your use case

What would you like to do?

Let's consider room 1 in a space. Room 1 is upgraded to room 2, and the space is updated with room 2 as a child instead of room 1. As a member of room 1 who hasn't joined room 2 yet, I would expect Element to show room 1 in the space, but it currently moves it to the "Home" section (since room 1 is not strictly speaking part of the space anymore).

Why would you like to do it?

I find it super confusing to have a room suddenly disappear from a space because the admin upgraded it. On top of that, room 1 might be referenced by other spaces which haven't been updated yet, so the room might move to somewhere other than "Home", which means the user may need to look through all of their spaces to find it.

How would you like to achieve it?

Element could look at a tombstone event in room 1 when the space is updated, and if that event points to a room that's in the space it could show the room as in that space.

Have you considered any alternatives?

I can't find any other than having the user look manually through Home and all of their spaces for the missing rooms.

Additional context

No response

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Sep 28, 2021

I partially believe this should be left in the hands of the space admins

@SimonBrandner SimonBrandner added A-Room-Upgrades A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Sep 28, 2021
@t3chguy
Copy link
Member

t3chguy commented Oct 19, 2021

This starts to break down, what if you're in many rooms with Tombstones pointing at RoomX, RoomX has now bifurcated into many rooms in your room list and look very strange when you're comparing the hierarchy calculated by the server and your room list in the left panel.

Right now EW does respect tombstones, but only when seeing a matching m.room.create backref, which means it needs to have the room locally

@nadonomy nadonomy added the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label Jan 21, 2022
@nadonomy
Copy link
Contributor

Triaging as major as users may fail to trace their rooms, and a room falling out of its space can easily erode trust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-Upgrades A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants