Notifications contain reply fallback from body

[Sr-Preet]

There exists user A and user B
User A and User B are logged into element on different machines

Steps-1) As User B send a reply of previous message to User A
As user A - Observe the notification received

Actual result-Matrix id of the user is displayed in the notification of reply

Expected result-Name of the user should be displayed instead of matrix id

[t3chguy]

Name of the user should be displayed instead of matrix id

This is unlikely to happen, the Notification is built on the body of the Matrix event being received, that body only contains the ID. This section should be stripped, it is a fallback only for legacy clients.

[Sr-Preet]

@t3chguy
Okay, So what can we do to resolve this.
This is happening on the current element-web as well as my custom build.

[t3chguy]

Notifier needs to gain something akin to stripReplyFallback in HtmlUtils

[Sr-Preet]

@t3chguy
Like bodyToHtml?

[t3chguy]

Yeah, might even be able to use that method

[Sr-Preet]

@t3chguy
How about this one?

It's working too.

[Sr-Preet]

@t3chguy
Can you take a look into this too?[#17860 ]

[t3chguy]

Open a pull request and it'll have to go through review.

[Sr-Preet]

@t3chguy Sure

[gabrc52]

This is especially annoying when a reply is long enough to take up the whole notification and you can't see the actual message from the notification

[gabrc52]

Thank you! Has this been fixed on mobile as well?

[t3chguy]

@gabrc52 you'd need to ask the repo responsible for the mobile application which you are using. There are tens if not hundreds of mobile Matrix clients available for use.