Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Membership list ordering broken #1740

Closed
dbkr opened this issue Jul 12, 2016 · 5 comments · Fixed by matrix-org/matrix-js-sdk#149 or matrix-org/matrix-react-sdk#340
Closed

Membership list ordering broken #1740

dbkr opened this issue Jul 12, 2016 · 5 comments · Fixed by matrix-org/matrix-js-sdk#149 or matrix-org/matrix-react-sdk#340

Comments

@dbkr
Copy link
Member

dbkr commented Jul 12, 2016

Expected: online, idle, offline then most recently active, actual: just by most recently active

@ara4n
Copy link
Member

ara4n commented Jul 12, 2016

This seems to be a regression of matrix-org/matrix-react-sdk#275

@dbkr
Copy link
Member Author

dbkr commented Jul 14, 2016

Looks like this may actually be something like the member list ordering correctly, but the information on the actual tiles being out of date.

@dbkr
Copy link
Member Author

dbkr commented Jul 14, 2016

Awaiting feedback to see if this is fixed

@dbkr
Copy link
Member Author

dbkr commented Jul 14, 2016

It isn't, but having looked together, looks like this is actually behaving as intended and may be visual confusion because greyed out offline users can have sooner last active times than online-but-not-currently-active users.

To fix this, we're going to make offline users with a last active time the same mid-grey as idle users.

@ara4n
Copy link
Member

ara4n commented Jul 31, 2016

...which then happened, and all is good in the world.

@ara4n ara4n closed this as completed Jul 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants