Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support drag and drop around spaces #16992

Open
t3chguy opened this issue Apr 19, 2021 · 7 comments
Open

Support drag and drop around spaces #16992

t3chguy opened this issue Apr 19, 2021 · 7 comments
Labels
A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design

Comments

@t3chguy
Copy link
Member

t3chguy commented Apr 19, 2021

Possible features:

  • Reordering rooms and spaces
  • Adding rooms/spaces to spaces
@t3chguy t3chguy added the A-Spaces Spaces, groups, communities label Apr 19, 2021
@robintown
Copy link
Member

Depending on two different versions of react-beautiful-dnd is always an option, right? Apart from bundle size concerns

@t3chguy
Copy link
Member Author

t3chguy commented Apr 19, 2021

Whilst yes webpack and npm support dependency aliasing for this purpose, there is 0 guarantee from the lib that it supports this.

It might register globals which conflict, I think the time wasted debugging issues with a dnd library is better spent on other things and dnd can come later.

@SimonBrandner SimonBrandner added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience X-Needs-Design X-Needs-Product More input needed from the Product team labels Nov 24, 2021
@niquewoodhouse niquewoodhouse added the S-Minor Impairs non-critical functionality or suitable workarounds exist label Jan 14, 2022
@daniellekirkwood
Copy link
Contributor

I'm going to remove the Needs-Product label as it would be great to have a drag&drop functionality in the app.

Ideally;

  • Subspaces can be drag&drop to move the ordering in the left panel (similarly to spaces).
  • Question: Can subspaces be drag&drop to different Spaces? Should we do that Design, can we do that Engineering?
  • Rooms can be drag&drop into Spaces or subspaces.

@daniellekirkwood daniellekirkwood removed the X-Needs-Product More input needed from the Product team label Apr 12, 2022
@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Apr 12, 2022

Additional questions;

  • If you drag a subspace between two spaces you own, would they "copy", or "move"?
  • Similarly, if you drag a subspace from a non-owned space to an owned one, would they unambiguously copy?
  • What about dragging a subspace from a space to the main bar? Would it be "pinned" in the sidebar? (Would this be "move" or "copy" as well?) (out of scope)

@t3chguy
Copy link
Member Author

t3chguy commented Apr 12, 2022

Keep in mind sometimes permissions might make it so you cannot move as you may not have the required permission to remove it from the "from" space.

What about dragging a subspace from a space to the main bar? Would it be "pinned" in the sidebar? (Would this be "move" or "copy" as well?)

This is out of scope as it'd require spec work.

@noantiq
Copy link

noantiq commented May 7, 2022

Hi! after opening an issue for dragging rooms into spaces (#22105) I was pointed here. I missed that a comment in this issue already reflects the use case since the issue title led me believe that this is only about re-ordering :D Maybe it would help to change the title or description of this issue accordingly?

@SimonBrandner SimonBrandner changed the title Support drag and drop for re-ordering space rooms and sub-spaces Support drag and drop around spaces May 7, 2022
@Reinachan
Copy link

Just adding that there is a spec for space maintainers to decide the room order in Matrix, m.space.child -> content -> order I'd suggest using that for specifying the order rooms appear in.
https://spec.matrix.org/v1.3/client-server-api/#ordering-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design
Projects
None yet
Development

No branches or pull requests

8 participants